[
https://issues.apache.org/jira/browse/IMPALA-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698396#comment-17698396
]
ASF subversion and git services commented on IMPALA-5446:
---------------------------------------------------------
Commit 7a3b8e365fe65651c67a7b8892ad3513f317cd2e in impala's branch
refs/heads/master from Daniel Becker
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7a3b8e365 ]
IMPALA-11983: Update stale comments in sorter.h referencing Init()
IMPALA-5446 replaced Sorter::Init() with Sorter::Prepare() and
Sorter::Open(), but comments in sorter.h still refer to Init().
This change updates these comments so they now refer to Prepare()
instead.
Change-Id: Ic3de8062d25cc226d5fea0cfb13a332e2e7f4aa4
Reviewed-on: http://gerrit.cloudera.org:8080/19599
Reviewed-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Daniel Becker <[email protected]>
Tested-by: Daniel Becker <[email protected]>
> Return Status from Sorter::Reset() is dropped
> ---------------------------------------------
>
> Key: IMPALA-5446
> URL: https://issues.apache.org/jira/browse/IMPALA-5446
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 2.3.0, Impala 2.5.0, Impala 2.4.0, Impala 2.6.0,
> Impala 2.7.0, Impala 2.8.0, Impala 2.9.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
> Labels: crash, nested_types
> Fix For: Impala 2.10.0
>
>
> Sorter::Reset() returns a Status, but it is dropped in SortNode::Reset():
> {code}
> Status SortNode::Reset(RuntimeState* state) {
> num_rows_skipped_ = 0;
> if (sorter_.get() != NULL) sorter_->Reset();
> return ExecNode::Reset(state);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
