[
https://issues.apache.org/jira/browse/IMPALA-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703863#comment-17703863
]
ASF subversion and git services commented on IMPALA-11964:
----------------------------------------------------------
Commit f2cb2c9ceb833d331fe2f78d9d3c9a5bcaeff7dd in impala's branch
refs/heads/master from Zoltan Borok-Nagy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f2cb2c9ce ]
IMPALA-11964: Make sure Impala returns error for Iceberg tables with equality
deletes
Impala only supports position deletes currently. It should raise an
error when equality deletes are encountered.
We already had a check for this when the query was planned by Iceberg.
But when we were using cached metadata the check was missing. This means
that Impala could return bogus results in the presence of equality
delete files. This patch adds check for the latter case as well.
Tables with equality delete files are still loadable by Impala, and
users can still query snapshots of it if they don't have equality
deletes.
Testing:
* added e2e tests
Change-Id: I14d7116692c0e47d0799be650dc323811e2ee0fb
Reviewed-on: http://gerrit.cloudera.org:8080/19601
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Make sure Impala returns error for Iceberg tables with equality deletes
> -----------------------------------------------------------------------
>
> Key: IMPALA-11964
> URL: https://issues.apache.org/jira/browse/IMPALA-11964
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
> Reporter: Zoltán Borók-Nagy
> Assignee: Zoltán Borók-Nagy
> Priority: Major
> Labels: impala-iceberg
>
> Impala only supports position deletes currently.
> It should raise an error when equality deletes are encountered:
> [https://github.com/apache/impala/blob/eaf71bca0a3538056765dbbce13c0f503045b38b/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java#L344]
> But if we are not invoking planFiles() it's possible that Impala starts
> reading equality delete files as position delete files which should also
> raise an error. But it would be still better to catch the error during
> planning.
> To make sure we should add tests for these scenarios.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
