[ 
https://issues.apache.org/jira/browse/IMPALA-12036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709129#comment-17709129
 ] 

ASF subversion and git services commented on IMPALA-12036:
----------------------------------------------------------

Commit ac23deab4ddc05b6b076b0767994d7bc58e8ef6a in impala's branch 
refs/heads/master from wzhou-code
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ac23deab4 ]

IMPALA-12036: Fix Web UI to show right resource pools

Web queries site shows no resource pool unless it is specified with
query option. The Planner could set TQueryCtx.request_pool in
TQueryExecRequest when auto scaling is enabled. But the backend
ignores the TQueryCtx.request_pool in TQueryExecRequest when getting
resource pools for Web UI.
This patch fixes the issue in ClientRequestState::request_pool() by
checking TQueryCtx.request_pool in TQueryExecRequest. It also
removes the error path in RequestPoolService::ResolveRequestPool() if
requested_pool is empty string.

Testing:
 - Updated TestExecutorGroups::test_query_cpu_count_divisor_default,
   TestExecutorGroups::test_query_cpu_count_divisor_two, and
   TestExecutorGroups::test_query_cpu_count_divisor_fraction to
   verify resource pools on Web queries site and Web admission site.
 - Updated expected error message in
   TestAdmissionController::test_set_request_pool.
 - Passed core test.

Change-Id: Iceacb3a8ec3bd15a8029ba05d064bbbb81e3a766
Reviewed-on: http://gerrit.cloudera.org:8080/19688
Reviewed-by: Riza Suminto <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Kurt Deschler <[email protected]>
Reviewed-by: Abhishek Rawat <[email protected]>


> Web UI incorrectly shows root.default resource pool for all queries in 
> /queries page
> ------------------------------------------------------------------------------------
>
>                 Key: IMPALA-12036
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12036
>             Project: IMPALA
>          Issue Type: Improvement
>            Reporter: Abhishek Rawat
>            Assignee: Wenzhe Zhou
>            Priority: Critical
>             Fix For: Impala 4.3.0
>
>
> Web UI seems to be always showing root.default resource pool even if a 
> different resource pool is used by the query. I also forced a different 
> resource pool by using `set REQUEST_POOL=root.group-set-00`, but Web UI still 
> showed `root.default`. This is reflected correctly in the query profiles but 
> not in the Web UI.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to