[ 
https://issues.apache.org/jira/browse/IMPALA-11273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17710353#comment-17710353
 ] 

Michael Smith commented on IMPALA-11273:
----------------------------------------

Most of these are straight-forward. Object.finalize is the only questionable 
one.

I don't think it's needed. It was added in the original commit 
([4800995d|https://github.com/apache/impala/commit/4800995d440f0966cf57c448c367e45ee54ece32])
 with no context why it might be needed. UdfExecutor looks to be exclusively 
created through calls from C++. The expression evaluator looks to always call 
close. Trying out some tests to see if it catches any unclosed executors.

> Get rid of deprecated API in Java 11
> ------------------------------------
>
>                 Key: IMPALA-11273
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11273
>             Project: IMPALA
>          Issue Type: Task
>            Reporter: Quanlong Huang
>            Assignee: Quanlong Huang
>            Priority: Major
>
> Frontend uses some Java APIs that are deprecated in Java 11:
> {code:java}
> $ cd $IMPALA_HOME
> $ source bin/impala-config.sh
> $ source bin/set-classpath.sh
> $ ~/software/jdk-11.0.2/bin/jdeprscan --release 11 --class-path "$CLASSPATH" 
> fe/target/impala-frontend-4.1.0-SNAPSHOT.jar
> Jar file fe/target/impala-frontend-4.1.0-SNAPSHOT.jar:
> class org/apache/impala/service/Frontend$CheckAuthorization uses deprecated 
> method java/lang/Boolean::<init>(Z)V 
> class org/apache/impala/planner/AnalyticPlanner uses deprecated method 
> java/lang/Boolean::<init>(Z)V 
> class org/apache/impala/planner/SingleNodePlanner uses deprecated method 
> java/lang/Long::<init>(J)V 
> class org/apache/impala/planner/SingleNodePlanner uses deprecated method 
> java/lang/Boolean::<init>(Z)V 
> class org/apache/impala/analysis/NumericLiteral uses deprecated method 
> java/math/BigDecimal::setScale(II)Ljava/math/BigDecimal; 
> class org/apache/impala/analysis/SelectStmt uses deprecated method 
> java/lang/Boolean::<init>(Z)V 
> class org/apache/impala/analysis/OrderByElement uses deprecated method 
> java/lang/Boolean::<init>(Z)V 
> class org/apache/impala/analysis/SqlScanner uses deprecated method 
> java/lang/Integer::<init>(I)V 
> class org/apache/impala/catalog/ColumnStats uses deprecated method 
> java/lang/Long::<init>(J)V 
> class org/apache/impala/catalog/ColumnStats uses deprecated method 
> java/lang/Double::<init>(D)V 
> class org/apache/impala/hive/executor/ImpalaStringWritable uses deprecated 
> method java/lang/Object::finalize()V 
> class org/apache/impala/hive/executor/ImpalaStringWritable overrides 
> deprecated method java/lang/Object::finalize()V 
> class org/apache/impala/hive/executor/UdfExecutor uses deprecated method 
> java/lang/Object::finalize()V 
> class org/apache/impala/hive/executor/UdfExecutor overrides deprecated method 
> java/lang/Object::finalize()V{code}
> We should update codes to get rid of them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to