[ 
https://issues.apache.org/jira/browse/IMPALA-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712397#comment-17712397
 ] 

Daniel Becker commented on IMPALA-12061:
----------------------------------------

As noted in the issue description it's not specific to PARQUET_BLOOM_FILTERING 
but applies to all boolean query options. I think we should remove 
PARQUET_BLOOM_FILTERING from the title (but we can use it as an example). 
IMPALA-11537 introduced validation for numeric query options, it could be 
extended to handle booleans.

> Throw Error for values other than 0, 1, true and false When 
> PARQUET_BLOOM_FILTERING query option is used
> --------------------------------------------------------------------------------------------------------
>
>                 Key: IMPALA-12061
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12061
>             Project: IMPALA
>          Issue Type: Task
>          Components: Backend
>    Affects Versions: Impala 4.0.0
>            Reporter: Prafful Agrawal
>            Priority: Major
>
> Right now, for most of the boolean query options, we can provide any number 
> or character and if the value is other than 1 and true, it is being 
> considered as 'false'. 
> For Example, when we use PARQUET_BLOOM_FILTERING query option, we can provide 
> any number or character and if the value is other than 1 and true, it is 
> being considered as 'false'. This creates confusion as a user might give 
> *PARQUET_BLOOM_FILTERING=t*
> or
> *PARQUET_BLOOM_FILTERING=12* _(any random values)_
> Then it will be considered as PARQUET_BLOOM_FILTERING=false. 
> User might use some value like 't' for 'true' but it would still be 
> considered as 'false'.
> +*Requirement:*+
> _Boolean query options_ should only take either of these values:
> 1 (binary for true)
> 0 (binary for false)
> true and false.
> Other than these 4 values, it should throw an error.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to