[
https://issues.apache.org/jira/browse/IMPALA-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714654#comment-17714654
]
Joe McDonnell commented on IMPALA-12064:
----------------------------------------
Toolchain commit
https://github.com/cloudera/native-toolchain/commit/1d05be3831d5cdcd8e72dbc15e7c7f09d56bc4cf
{noformat}
commit 1d05be3831d5cdcd8e72dbc15e7c7f09d56bc4cf
Author: Joe McDonnell <[email protected]>
Date: Fri Apr 14 16:51:39 2023 -0700 IMPALA-12064: Remove unused component
versions (boost, thrift, openssl)
This removes some unused components and versions:
Boost 1.57.0-p3 - no longer used
Boost 1.61.0-p2 - no longer used
GDB 10.2 - never used
GDB 11.2 - never used
KRB 1.15.1 - Impala uses OS version
OpenSSL 1.0.2l - Impala uses OS version by default
Thrift 0.13.0-p4 - never used
Thrift 0.14.2-p4 - never used
The OpenSSL code in the Thrift build is dead code from
when we supported older OSes that had much older OpenSSL.
Impala does not use toolchain OpenSSL, but it will need
modifications to adapt to its absence.
This also fixes the Boost and Thrift builds to go parallel
properly. Boost had been limiting itself to 4 threads
unnecessarily. Thrift had been building serially. Now,
both go parallel with the specific BUILD_THREADS value.
Testing:
- Ran toolchain build
Change-Id: I07c21722c0849a1f6eeb3953a6e432d89623cf72
Reviewed-on: http://gerrit.cloudera.org:8080/19753
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Joe McDonnell <[email protected]>
{noformat}
> Remove unused toolchain components versions (boost, thrift)
> -----------------------------------------------------------
>
> Key: IMPALA-12064
> URL: https://issues.apache.org/jira/browse/IMPALA-12064
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> The toolchain build is building some old versions of libraries that are not
> currently in used. Specifically:
> {noformat}
> boost-1.57.0-p3 (old)
> boost-1.61.0-p2 (old)
> thrift-0.13.0-p4 (never used)
> thrift-0.14.2-p4 (never used)
> openssl 1.0.2 (comes from OS, not toolchain)
> krb5 1.15.1 (comes from OS, not toolchain){noformat}
> While we're here, we need to fix that the Boost build limits itself to -j4:
> {noformat}
> wrap ./b2 -s"NO_BZIP2=1" $TOOLSET cxxflags="$CXXFLAGS"
> linkflags="$CXXFLAGS" --prefix=$LOCAL_INSTALL -j4 install{noformat}
> And thrift doesn't go parallel when it now works on recent Thrift versions:
> {noformat}
> wrap make install # Thrift 0.9.0 doesn't build with
> -j${BUILD_THREADS}{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
