[ 
https://issues.apache.org/jira/browse/IMPALA-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720620#comment-17720620
 ] 

ASF subversion and git services commented on IMPALA-11123:
----------------------------------------------------------

Commit 7ca20b3c94b1c9c1ddd4ed1e89f0969a0df55330 in impala's branch 
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7ca20b3c9 ]

Revert "IMPALA-11123: Optimize count(star) for ORC scans"

This reverts commit f932d78ad0a30e322d59fc39072f710f889d2135.

The commit is reverted because it cause significant regression for
non-optimized counts star query in parquet format.

There are several conflicts that need to be resolved manually:
- Removed assertion against 'NumFileMetadataRead' counter that is lost
  with the revert.
- Adjust the assertion in test_plain_count_star_optimization,
  test_in_predicate_push_down, and test_partitioned_insert of
  test_iceberg.py due to missing improvement in parquet optimized count
  star code path.
- Keep the "override" specifier in hdfs-parquet-scanner.h to pass
  clang-tidy
- Keep python3 style of RuntimeError instantiation in
  test_file_parser.py to pass check-python-syntax.sh

Change-Id: Iefd8fd0838638f9db146f7b706e541fe2aaf01c1
Reviewed-on: http://gerrit.cloudera.org:8080/19843
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Wenzhe Zhou <[email protected]>


> Optimize count(*) for ORC scans
> -------------------------------
>
>                 Key: IMPALA-11123
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11123
>             Project: IMPALA
>          Issue Type: Improvement
>            Reporter: Quanlong Huang
>            Assignee: Riza Suminto
>            Priority: Critical
>              Labels: ramp-up
>             Fix For: Impala 4.1.0
>
>
> IMPALA-5036 and IMPALA-6501 added an optimisation for count\(*\) in Parquet 
> and Kudu scans that avoids materialising dummy rows. We should do something 
> similar for ORC.
> Refer IMPALA-5036 for more details.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to