[ 
https://issues.apache.org/jira/browse/IMPALA-12413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762786#comment-17762786
 ] 

ASF subversion and git services commented on IMPALA-12413:
----------------------------------------------------------

Commit 0f55e551bc98843c79a9ec82582ddca237aa4fe9 in impala's branch 
refs/heads/master from Zoltan Borok-Nagy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=0f55e551b ]

IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala

Trino creates Iceberg tables without 'engine.hive.enabled'='true'. It
also doesn't provide a way for users to set this property. Therefore
Trino always creates Iceberg tables with non-HiveIceberg storage
descriptors.

Impala uses the Input/Output/SerDe properties to recognize table types.
This change relaxes this a bit for Iceberg tables, i.e. a table is also
considered to be an Iceberg table if the table property
'table_type'='ICEBERG' is set.

During table loading Impala uses an internal HDFS table to load table
metadata. It currently throws an exception when no proper storage
descriptor is being set. To workaround this, IcebergTable changes
the in-memory HMS table's storage descriptor properties to the
HiveIceberg* properties. Normally, this shouldn't persist to the
HMS database on read operations. Though it wouldn't harm AFAICT, we
just want to be on the safe side.

Modifications to the table from Impala goes through its Iceberg
libary (with 'engine.hive.enabled'='true'), which means we set
the HiveIceberg storage descriptors. Trino is still compatible with
such tables.

Testing
 * Manually tested with Trino
 * IMPALA-12422 will add interop tests once we have Trino in the
   minicluster environment

Change-Id: I18ea3858314d70a6131982a4e4d3ca90a95a311a
Reviewed-on: http://gerrit.cloudera.org:8080/20453
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Make Iceberg tables created by Trino compatible with Impala
> -----------------------------------------------------------
>
>                 Key: IMPALA-12413
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12413
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Catalog
>            Reporter: Zoltán Borók-Nagy
>            Assignee: Zoltán Borók-Nagy
>            Priority: Major
>              Labels: impala-iceberg
>
> Currently Iceberg tables created by Trino are not compatible with Impala as 
> Trino doesn't set storage_handler property and storage descriptors.
> It only denotes the table type via the table property 'table_type' which is 
> set to Iceberg.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to