[
https://issues.apache.org/jira/browse/IMPALA-12432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764047#comment-17764047
]
ASF subversion and git services commented on IMPALA-12432:
----------------------------------------------------------
Commit 1642886b41a83302f12dd95cbee763060f5bef5d in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1642886b4 ]
IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28
In the change for IMPALA-11726, we added some usages of
Guava's ImmutableMap.of() with >5 key/value pairs. This
won't compile in older versions of Guava (like Guava 28)
that only support up to 5 key/value pairs in ImmutableMap.of().
Being compatible with older versions of Guava makes it
easier for Impala to match the Guava version of Hadoop,
Hive, etc when compiling against older versions.
This switches to using ImmutableMap.builder() to build
the larger maps.
Testing:
- Built with Guava 28 and ran the tests
Change-Id: Ic6d9c69fff749bcdb0887a6676574db9526f68e8
Reviewed-on: http://gerrit.cloudera.org:8080/20471
Reviewed-by: Michael Smith <michael.sm...@cloudera.com>
Tested-by: Michael Smith <michael.sm...@cloudera.com>
> Keep LdapKerberosImpalaShellTest* compatible with older guava versions
> ----------------------------------------------------------------------
>
> Key: IMPALA-12432
> URL: https://issues.apache.org/jira/browse/IMPALA-12432
> Project: IMPALA
> Issue Type: Task
> Components: Frontend
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Priority: Major
> Fix For: Impala 4.3.0
>
>
> LdapKerberosImpalaShellTestBase.java and LdapKerberosImpalaShellTest.java use
> the ImmutableMap.of function with 8+ pairs. Older versions of guava like
> 28.1-jre do not have ImmutableMap.of() for that number of arguments.
> Since we often want to use the guava version that the underlying Hadoop/Hive
> use, it can be useful for compatibility to be able to build against older
> guava (like 28.1-jre).
> Most other code is fine, so if we switch these locations to use
> ImmutableMap.<String, String>builder(), then the whole codebase can compile
> with the older guava (while remaining forward compatible as well).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
