[
https://issues.apache.org/jira/browse/IMPALA-12482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772830#comment-17772830
]
ASF subversion and git services commented on IMPALA-12482:
----------------------------------------------------------
Commit 72cc1bccbf3a2de8b4b17f77af9223a96e22fa11 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=72cc1bccb ]
IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
Not all RPC need to print logs at VLOG level 2. For example,
StatestoreSubscriber.UpdateState is a periodic RPC that happens every 1
second. Debugging impalad through lowering VLOG lovel to 2 has been
difficult due to noise from this StatestoreSubscriber.UpdateState RPC
that buries other more important log lines.
This patch add vlog_level parameter in RpcEventHandler to make log level
for different kind of RPC adjustable.
Testing:
- Manually test that log lines from StatestoreSubscriber.UpdateState is
not printed anymore after lowering backend VLOG level to 2.
Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Reviewed-on: http://gerrit.cloudera.org:8080/20537
Reviewed-by: Wenzhe Zhou <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> StatestoreSubscriber.UpdateState logging is too noisy at VLOG level 2
> ---------------------------------------------------------------------
>
> Key: IMPALA-12482
> URL: https://issues.apache.org/jira/browse/IMPALA-12482
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 4.3.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> StatestoreSubscriber.UpdateState is a periodic RPC that happens every 1
> second. This RPC is wrapped with RpcEventHandler (rpc-trace.cc) which has
> VLOG_RPC (or VLOG(2)) in it.
> Debugging Impalad by lowering VLOG level from 1 to 2 has been difficult due
> to noise from this StatestoreSubscriber.UpdateState RPC. Following lines will
> be printed to Impalad logs, burying other log lines that is actually more
> important:
> {code:java}
> I0926 15:54:15.255978 829 rpc-trace.cc:256] RPC call:
> statestore-subscriber:StatestoreSubscriber.UpdateState from 127.0.0.6:41953
> took 123.000us
> I0926 15:54:15.356801 848 rpc-trace.cc:236] RPC call:
> StatestoreSubscriber.UpdateState(from 127.0.0.6:35361) {code}
> RpcEventHandler should be modified to allow different VLOG level for
> different RPC handler.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
