[
https://issues.apache.org/jira/browse/IMPALA-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775788#comment-17775788
]
ASF subversion and git services commented on IMPALA-12399:
----------------------------------------------------------
Commit 62b6081852b4851437f554aa68aa8321099568b0 in impala's branch
refs/heads/master from Venu Reddy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=62b608185 ]
IMPALA-12399: (addendum) Fixed possible deadloop and also do not set
the event skip list in notification request to update latestEventId_
Following points are fixed:
1. Possible deadloop in
MetastoreEventsProcessor#getNextMetastoreEventsInBatches()
when OPEN_TXN is the last event on HMS at the moment the
method is invoked. Need to return when events received
in response is empty.
2. latestEventId_ reflects the latest event in HMS. Should
not set the event skip list in notification request to
update latestEventId_.
3. Update lastSyncedEventId_ when event list returned is
empty due to event skip list in notification event.
Testing:
- Added tests and executed all existing tests.
Change-Id: Idb4b8c3db23d39226f10b33cca4e6a1ab271b925
Reviewed-on: http://gerrit.cloudera.org:8080/20487
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Pass eventTypeSkipList with OPEN_TXN in NotificationEventRequest to avoid
> receiving OPEN_TXN events from HMS
> ------------------------------------------------------------------------------------------------------------
>
> Key: IMPALA-12399
> URL: https://issues.apache.org/jira/browse/IMPALA-12399
> Project: IMPALA
> Issue Type: Improvement
> Components: Catalog
> Reporter: Venugopal Reddy K
> Assignee: Venugopal Reddy K
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Notification events like OPEN_TXN are ignored on catalogd
> {{{}MetastoreEventsProcessor{}}}. So, we can pass eventTypeSkipList with
> OPEN_TXN in NotificationEventRequest while invoking get_next_notification()
> to avoid reading such notification messages from HMS and then ignoring on
> catalogd. OPEN_TXN event being more frequent(received even upon describe
> table operation from beeline), we can significantly reduce unwanted
> processing on both HMS and catalogd. Catalogd reads events in batches of
> EVENTS_BATCH_SIZE_PER_RPC, skipping such unnecessary events can help catchup
> the events faster.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
