[
https://issues.apache.org/jira/browse/IMPALA-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781113#comment-17781113
]
ASF subversion and git services commented on IMPALA-12524:
----------------------------------------------------------
Commit 6811a008851ba4637f1caaf4e272036e5da0fbc6 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6811a0088 ]
IMPALA-12524: Deduplicate TestTextScanRangeLengths
This patch deduplicates TestTextScanRangeLengths in test_scanners.py by
renaming them to TestTextScanRangeLengths1 and
TestTextScanRangeLengths2.
This patch also renames two test classes in test_local_catalog.py:
TestCompactCatalogUpdates that duplicates
test_compact_catalog_updates.py::TestCompactCatalogUpdates and
TestObservability that duplicates
test_observability.py::TestObservability.
Testing:
- Ran test_scanners.py and confirm that both TestTextScanRangeLengths1
and TestTextScanRangeLengths2 are run.
- Run and pass test_local_catalog.py.
- Checked with git grep that all pytest class names are unique.
git grep "^class Test" tests/ | cut -d":" -f2 | sort | uniq -c | sort
Change-Id: I1c26d8b7d20960b54b4d2ded3bb3f32b34c3b544
Reviewed-on: http://gerrit.cloudera.org:8080/20630
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Duplicate TestTextScanRangeLengths in test_scanners.py
> ------------------------------------------------------
>
> Key: IMPALA-12524
> URL: https://issues.apache.org/jira/browse/IMPALA-12524
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Minor
>
> There is a duplicate TestTextScanRangeLengths class in test_scanners.py
> [https://github.com/apache/impala/blob/248060528abd7fb5425f519ee1608598ed2d3ac3/tests/query_test/test_scanners.py#L1377]
> [https://github.com/apache/impala/blob/248060528abd7fb5425f519ee1608598ed2d3ac3/tests/query_test/test_scanners.py#L1494]
>
> The name should be unique for both test class within same file to run
> properly.
> Simple grep found another duplicates at TestObservability and
> TestCompactCatalogUpdates. These other duplicates does not cause issue
> because they are defined in separate test files: test_local_catalog.py,
> test_observability.py, and test_compact_catalog_updates.py. But ideally they
> should be distinguishable.
> {code:java}
> $ git grep "^class Test" tests/ | cut -d":" -f2 | sort |uniq -c | sort | tail
> -n 5
> 1 class TestZippingUnnestFromView(ImpalaTestSuite)
> 1 class TestZippingUnnest(ImpalaTestSuite)
> 2 class TestCompactCatalogUpdates(CustomClusterTestSuite)
> 2 class TestObservability(CustomClusterTestSuite)
> 2 class TestTextScanRangeLengths(ImpalaTestSuite) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
