[
https://issues.apache.org/jira/browse/IMPALA-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783426#comment-17783426
]
Quanlong Huang commented on IMPALA-10268:
-----------------------------------------
To add the check, we can validate the query option in impala::SetQueryOption():
[https://github.com/apache/impala/blob/36640548e6c8ca2638a170cbbb8b10af468003e9/be/src/service/query-options.cc#L197]
> Validate the debug actions when they are set
> --------------------------------------------
>
> Key: IMPALA-10268
> URL: https://issues.apache.org/jira/browse/IMPALA-10268
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Vihang Karajgaonkar
> Priority: Minor
> Labels: newbie
>
> Impala has a query option called {{debug_action}} which can be set to invoke
> some debug code like adding a sleep statement to simulate delay. Currently
> the implementation of this debug action also validates whether the action is
> a correctly formatted as seen in
> https://github.com/apache/impala/blob/198bbe280cb991f653eba18c3d49b35582608520/be/src/util/debug-util.cc#L355.
> However, if the debug_action is not correctly set up, this code can throw
> exceptions at places where it is invoked. It would be good to validate the
> debug action when the query option is set so that a invalid string is not
> passed to the debug action execution.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
