[
https://issues.apache.org/jira/browse/IMPALA-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798629#comment-17798629
]
Sean Yeh edited comment on IMPALA-5078 at 12/19/23 3:31 PM:
------------------------------------------------------------
[~csringhofer]
Do you think you could give me until December 22nd 5 pm PST?
If I fail to send out a MR/PR by that time, this ticket is all yours.
Ideally, I'd like to give it one last shot.
was (Author: sy117):
[~csringhofer]
Do you think you could give me until December 22nd 5 pm PST?
If I fail to send out a MR/PR by that time, this ticket is all yours.
> Break up expr-test.cc
> ---------------------
>
> Key: IMPALA-5078
> URL: https://issues.apache.org/jira/browse/IMPALA-5078
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Henry Robinson
> Assignee: Csaba Ringhofer
> Priority: Minor
> Labels: newbie, ramp-up
> Attachments: Screen Shot 2020-06-30 at 12.19.16 PM.png, Screen Shot
> 2020-07-10 at 1.01.43 PM.png, Screen Shot 2020-07-10 at 11.16.36 AM.png,
> Screen Shot 2020-07-10 at 11.27.57 AM.png, image-2020-07-10-13-22-48-230.png
>
>
> {{expr-test.cc}} clocks in at 7129 lines, which is about enough for my emacs
> to start slowing down a bit. Let's see if we can refactor it enough to have a
> couple of test files. Maybe moving all the string instructions into a
> separate {{expr-string-test.cc}}, and having a common header will be enough
> to make it a bit more manageable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
