[
https://issues.apache.org/jira/browse/IMPALA-12633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799526#comment-17799526
]
ASF subversion and git services commented on IMPALA-12633:
----------------------------------------------------------
Commit 6c6142ba2e602d0c37543c81dfcd0652455e6368 in impala's branch
refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6c6142ba2 ]
IMPALA-12633: Remove DCHECK for slow SetQueryInflight
Removes the DCHECK that the original query is inflight before trying to
close it during a query retry. SetQueryInflight is a separate operation
the server performs after a query has started executing async, and it's
possible for the query to fail and retry before the server calls
SetQueryInflight. When that happens, we still need to perform cleanup
or the original request_state is never closed and we hit a different
DCHECK: "BlockOnWait() needs to be called!"
Adds an option to CloseClientRequestState for when we close a
ClientRequestState but the query is retrying with a new state. It
ensures that we bypass most of SetQueryInflight in case
CloseClientRequestState was called first.
Updates the message from DCHECK in ClientRequestState's destructor to
reflect that wait_thread_ is only reset in Finalize.
Adds a debug action and test where just the original query is delayed
during the SetQueryInflight call.
Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7
Reviewed-on: http://gerrit.cloudera.org:8080/20799
Reviewed-by: Riza Suminto <[email protected]>
Reviewed-by: Wenzhe Zhou <[email protected]>
Reviewed-by: Quanlong Huang <[email protected]>
Tested-by: Michael Smith <[email protected]>
> DCHECK failure on query_handle->is_inflight()
> ---------------------------------------------
>
> Key: IMPALA-12633
> URL: https://issues.apache.org/jira/browse/IMPALA-12633
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 4.4.0
> Reporter: Andrew Sherman
> Assignee: Michael Smith
> Priority: Critical
> Fix For: Impala 4.4.0
>
> Attachments: 951ee391-85bd-4fdb-b43550a1-7564a485.dmp_dumped
>
>
> This is a new DCHECK introduced in IMPALA-12493
> {code}
> 12 impalad!google::LogMessageFatal::~LogMessageFatal() + 0x9
> rsp = 0x00007fd0d4e5d2b0 rip = 0x00000000038f8ad9
> Found by: stack scanning
> 13 impalad!impala::QueryDriver::RetryQueryFromThread(impala::Status
> const&, std::shared_ptr<impala::QueryDriver>) [query-driver.cc :
> 376 + 0xc]
> rsp = 0x00007fd0d4e5d2c0 rip = 0x0000000002295372
> Found by: stack scanning
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
