[
https://issues.apache.org/jira/browse/IMPALA-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799678#comment-17799678
]
Csaba Ringhofer commented on IMPALA-5078:
-----------------------------------------
[~sy117] I had a work in progress patch for this that moves timestamp/date
related functions to a separate file and also collects some shared
functionality to a common header:
https://github.com/csringhofer/Impala/commit/0b8967fa7aa24c9df2d6327c1594e811ba853572
It still needs a lot of cleanup but at least it compiles. Feel free to use it
or ignore it.
Besides cleanup, it would be nice to move some other functionality, e.g. string
or decimal functions to separate files.
> Break up expr-test.cc
> ---------------------
>
> Key: IMPALA-5078
> URL: https://issues.apache.org/jira/browse/IMPALA-5078
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Henry Robinson
> Assignee: Csaba Ringhofer
> Priority: Minor
> Labels: newbie, ramp-up
> Attachments: Screen Shot 2020-06-30 at 12.19.16 PM.png, Screen Shot
> 2020-07-10 at 1.01.43 PM.png, Screen Shot 2020-07-10 at 11.16.36 AM.png,
> Screen Shot 2020-07-10 at 11.27.57 AM.png, image-2020-07-10-13-22-48-230.png
>
>
> {{expr-test.cc}} clocks in at 7129 lines, which is about enough for my emacs
> to start slowing down a bit. Let's see if we can refactor it enough to have a
> couple of test files. Maybe moving all the string instructions into a
> separate {{expr-string-test.cc}}, and having a common header will be enough
> to make it a bit more manageable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
