[
https://issues.apache.org/jira/browse/IMPALA-12676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803355#comment-17803355
]
ASF subversion and git services commented on IMPALA-12676:
----------------------------------------------------------
Commit aa36259d9f5df180eb6ec30c8a43ca09bcc0ce4d in impala's branch
refs/heads/master from jasonmfehr
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=aa36259d9 ]
IMPALA-12676: Fix integer overflow in DatabaseTest
Fixes an integer overflow issue in the DatabaseTest class
in the internal-server-test.cc file by switching from a
signed to an unsigned int. Additional comments and
assertions were also added to prevent future
integer overflows.
Change-Id: I3689185aa8676203226cc447585703e784627102
Reviewed-on: http://gerrit.cloudera.org:8080/20856
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Michael Smith <[email protected]>
> UBSAN intermittent int overflow on internal-server-test
> -------------------------------------------------------
>
> Key: IMPALA-12676
> URL: https://issues.apache.org/jira/browse/IMPALA-12676
> Project: IMPALA
> Issue Type: Bug
> Affects Versions: Impala 4.4.0
> Reporter: Michael Smith
> Assignee: Jason Fehr
> Priority: Major
> Fix For: Impala 4.4.0
>
>
> internal-server-test intermittently fails UBSAN runs with
> {code}
> [ RUN ] InternalServerTest.SimultaneousMultipleQueriesOneSession
> /data/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/src/service/internal-server-test.cc:149:42:
> runtime error: signed integer overflow: 31536000 * 81 cannot be represented
> in type 'int'
> #0 0x1f5a6dc in
> impala::internalservertest::DatabaseTest::DatabaseTest(std::shared_ptr<impala::ImpalaServer>,
> std::__cxx11::basic_string<char, std::char_traits<char>,
> std::allocator<char> >, bool, int)
> /data/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/src/service/internal-server-test.cc:149:42
> #1 0x1f514f4 in
> impala::internalservertest::InternalServerTest_SimultaneousMultipleQueriesOneSession_Test::TestBody()
>
> /data/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/src/service/internal-server-test.cc:487:26
> #2 0x8f0161c in void
> testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*)
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8f0161c)
> #3 0x8efa534 in testing::Test::Run()
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8efa534)
> #4 0x8efa677 in testing::TestInfo::Run()
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8efa677)
> #5 0x8efa754 in testing::TestCase::Run()
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8efa754)
> #6 0x8efac4b in testing::internal::UnitTestImpl::RunAllTests()
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8efac4b)
> #7 0x8efacf2 in testing::UnitTest::Run()
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8efacf2)
> #8 0x1f535e5 in main
> /data/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/src/service/internal-server-test.cc:547:22
> #9 0x7f3802a81554 in __libc_start_main (/lib64/libc.so.6+0x22554)
> #10 0x1f21f26 in _start
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x1f21f26)
> /data/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/src/service/internal-server-test.cc:172:36:
> runtime error: signed integer overflow: 31536000 * 100 cannot be represented
> in type 'int'
> #0 0x1f5b1fd in
> impala::internalservertest::DatabaseTest::DatabaseTest(std::shared_ptr<impala::ImpalaServer>,
> std::__cxx11::basic_string<char, std::char_traits<char>,
> std::allocator<char> >, bool, int)
> /data/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/src/service/internal-server-test.cc:172:36
> #1 0x1f514f4 in
> impala::internalservertest::InternalServerTest_SimultaneousMultipleQueriesOneSession_Test::TestBody()
>
> /data/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/src/service/internal-server-test.cc:487:26
> #2 0x8f0161c in void
> testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*)
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8f0161c)
> #3 0x8efa534 in testing::Test::Run()
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8efa534)
> #4 0x8efa677 in testing::TestInfo::Run()
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8efa677)
> #5 0x8efa754 in testing::TestCase::Run()
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8efa754)
> #6 0x8efac4b in testing::internal::UnitTestImpl::RunAllTests()
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8efac4b)
> #7 0x8efacf2 in testing::UnitTest::Run()
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x8efacf2)
> #8 0x1f535e5 in main
> /data/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/src/service/internal-server-test.cc:547:22
> #9 0x7f3802a81554 in __libc_start_main (/lib64/libc.so.6+0x22554)
> #10 0x1f21f26 in _start
> (/data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/build/debug/service/internal-server-test+0x1f21f26)
> Minidump with no thread info available.
> Minidump with no thread info available.
> Wrote minidump to
> /data/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/logs/be_tests/minidumps/internal-server-test/1bf71382-765d-48dd-1c82c695-d94e9fa9.dmp
> Wrote minidump to
> /data/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/logs/be_tests/minidumps/internal-server-test/1bf71382-765d-48dd-1c82c695-d94e9fa9.dmp
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGSEGV (0xb) at pc=0x000000000278364f, pid=19228, tid=0x00007f36c5043700
> #
> # JRE version: Java(TM) SE Runtime Environment (8.0_261-b12) (build
> 1.8.0_261-b12)
> # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.261-b12 mixed mode
> linux-amd64 compressed oops)
> # Problematic frame:
> # C [internal-server-test+0x238364f]
> impala::TPlanFragment::TPlanFragment(impala::TPlanFragment const&)+0x14f
> #
> # Core dump written. Default location:
> /data0/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/be/src/service/core
> or core.19228
> #
> # An error report file with more information is saved as:
> #
> /data/jenkins/workspace/impala-asf-master-core-ubsan/repos/Impala/logs/hs_err_pid19228.log
> #
> # If you would like to submit a bug report, please visit:
> # http://bugreport.java.com/bugreport/crash.jsp
> #
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
