Joe McDonnell created IMPALA-12730:
--------------------------------------
Summary: Avoid Weverything for Clang Tidy
Key: IMPALA-12730
URL: https://issues.apache.org/jira/browse/IMPALA-12730
Project: IMPALA
Issue Type: Improvement
Components: Infrastructure
Affects Versions: Impala 4.4.0
Reporter: Joe McDonnell
When building Impala for Clang Tidy, we turn on -Weverything
{noformat}
SET(CXX_FLAGS_TIDY "${CXX_FLAGS_TIDY} -Wall -W -Weverything -Wno-c++98-compat
-Wno-padded"){noformat}
Clang Tidy uses these warnings to implement the "clang-diagnostic" Clang Tidy
issues. The other Clang Tidy checkers don't need Weverything to function. Since
we now use -Werror for our Clang builds, I think anything we would want to find
with this could also be found by adding extra warnings to the regular Clang
build.
Weverything is super verbose and makes build failures much harder to find in
the logs. It changes across Clang versions. In general, I think it is not worth
it anymore. We could remove it and clean up .clang-tidy.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
