Joe McDonnell created IMPALA-12804:
--------------------------------------
Summary: C files should be compiled with equivalent flags as the
C++ files
Key: IMPALA-12804
URL: https://issues.apache.org/jira/browse/IMPALA-12804
Project: IMPALA
Issue Type: Improvement
Components: Backend
Affects Versions: Impala 4.3.0
Reporter: Joe McDonnell
Impala's be/CMakeLists.txt does calculations to determine CMAKE_CXX_FLAGS, but
it does not set CMAKE_C_FLAGS. This means that C files don't get the options
that we specify on C++ files. This is pretty minor, because there are very few
C files in the codebase. Even so, it would be good to specify similar flags for
CMAKE_C_FLAGS when we set CMAKE_CXX_FLAGS.
As an example, be/src/thirdparty/squeasel/squeasel.c won't be compiled with
'-fno-omit-frame-pointer' or debug information for release builds. If it fails
during webserver startup (e.g. when it tries to read the private key to setup
SSL), the resulting stack in the minidump is jumbled a bit.
This should be relatively easy to fix, but it may involve reorganizing the way
we calculate CMAKE_CXX_FLAGS.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
