Joe McDonnell created IMPALA-12813:
--------------------------------------

             Summary: Log a message when the webserver_private_key_password_cmd 
succeeds
                 Key: IMPALA-12813
                 URL: https://issues.apache.org/jira/browse/IMPALA-12813
             Project: IMPALA
          Issue Type: Improvement
          Components: Backend
    Affects Versions: Impala 4.3.0
            Reporter: Joe McDonnell


When we start Thrift with SSL, we print a message indicating that the 
ssl_private_key_password_cmd succeeded:
{noformat}
  if (!pem_password_cmd.empty()) {
    if (!RunShellProcess(pem_password_cmd, &key_password_, true, 
{"JAVA_TOOL_OPTIONS"})) {
      return Status(TErrorCode::SSL_PASSWORD_CMD_FAILED, pem_password_cmd, 
key_password_);
    } else {
      LOG(INFO) << "Command '" << pem_password_cmd << "' executed successfully, 
"
                << ".PEM password retrieved";
    }
  }{noformat}
We don't print a message for the webserver's webserver_private_key_password_cmd:
{noformat}
      const string& password_cmd = FLAGS_webserver_private_key_password_cmd;
      if (!password_cmd.empty()) {
        if (!RunShellProcess(password_cmd, &key_password, true, 
{"JAVA_TOOL_OPTIONS"})) {
          return Status(TErrorCode::SSL_PASSWORD_CMD_FAILED, password_cmd, 
key_password);
        }
        options.push_back("ssl_private_key_password");
        options.push_back(key_password.c_str());
      }{noformat}
We should print a message indicating that the command succeeded.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to