[ 
https://issues.apache.org/jira/browse/IMPALA-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821454#comment-17821454
 ] 

ASF subversion and git services commented on IMPALA-12842:
----------------------------------------------------------

Commit 3a6987e09b7f76b2b2c4c7c3b599cbdd4b509209 in impala's branch 
refs/heads/master from Laszlo Gaal
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=3a6987e09 ]

IMPALA-12842: Make node.js installation aware of CPU architecture

The earlier version of the installation logic in
tests/run-js-test-on-arm.sh always used 'linux-x86' as the architecture
tag for the downloaded node.js installation package, which made the
tests themselves fail when running on an instance powered by an ARM
(Graviton) CPU.

This patch uses the $ARCH_NAME environment variable set up in
bin/impala-config.sh to add the correct CPU architecture tag to the URL
of the node.js package to be downloaded. If the rported CPU type is not
one of the known types (x86_64 or aarch64), the installation step throws
and error and emits a JUnit XML symptom for Jenkins runs.

Change-Id: Ie22da6237ed6d19cf8af721df471033fdfe6b23a
Reviewed-on: http://gerrit.cloudera.org:8080/21070
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Reviewed-by: Surya Hebbar <sheb...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> JS_TEST fails on ARM instances on node.js binaries installed for wrong CPU 
> architecture
> ---------------------------------------------------------------------------------------
>
>                 Key: IMPALA-12842
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12842
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 4.4.0
>            Reporter: Laszlo Gaal
>            Assignee: Laszlo Gaal
>            Priority: Blocker
>              Labels: arm, arm64, broken-build
>
> JS_TESTs can install the required node.js binaries on the fly before running 
> the test steps. Unfortunately the installation steps hardcode the CPU 
> architecture as x86_64 in 
> https://github.com/apache/impala/blob/master/tests/run-js-tests.sh#L27, which 
> causes a failure later if the tests are run on an instance with an aarch64 
> (Graviton) CPU.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to