[
https://issues.apache.org/jira/browse/IMPALA-12821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822604#comment-17822604
]
ASF subversion and git services commented on IMPALA-12821:
----------------------------------------------------------
Commit 30fbcc94ea08bb0a5eb58d68bcce9c2a0eb9750e in impala's branch
refs/heads/master from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=30fbcc94e ]
IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
When event-processor goes into the error state, event related labels
like 'Fetched event batch from Metastore' won't be added into the DDL
profiles, which makes test_create_table_profile_events fail.
This patch removes the event related labels in the test. So it's
expected to pass with or without event processor enabled. Also dumps the
actual profiles when the test fails.
Tests:
- Run the test when event-processor is disabled.
Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Reviewed-on: http://gerrit.cloudera.org:8080/21040
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> test_create_table_profile_events fails if event-processor is stopped
> --------------------------------------------------------------------
>
> Key: IMPALA-12821
> URL: https://issues.apache.org/jira/browse/IMPALA-12821
> Project: IMPALA
> Issue Type: Bug
> Reporter: Quanlong Huang
> Assignee: Quanlong Huang
> Priority: Major
>
> test_create_table_profile_events could fail due to "Fetched event batch from
> Metastore" not found in the query profile:
> {noformat}
> query_test/test_observability.py:487: in test_create_table_profile_events
> "DDL finished"
> query_test/test_observability.py:522: in __verify_event_labels_in_profile
> assert label in profile
> E assert 'Fetched event batch from Metastore' in 'Query
> (id=5445c5c5b44dcc6b:beb0d40100000000):\n Summary:\n Session ID:
> ea43c7f87eaf82d5:5464e9acfdaf11ad\n Ses...: 6.000us\n - RPCWriteTimer:
> 55.000us\n - RowMaterializationRate: 0\n - RowMaterializationTimer:
> 0.000ns\n'{noformat}
> The cause is that event-processor was stopped due to an error. In such case,
> this timeline label won't be added.
> {code:java}
> private static final String FETCHED_HMS_EVENT_BATCH =
> "Fetched event batch from Metastore";
> private List<NotificationEvent> getNextMetastoreEventsIfEnabled(
> EventSequence catalogTimeline, long eventId, NotificationFilter
> eventsFilter)
> throws MetastoreNotificationException {
> if (!catalog_.isEventProcessingActive()) return Collections.emptyList();
> List<NotificationEvent> events = MetastoreEventsProcessor
> .getNextMetastoreEventsInBatches(catalog_, eventId, eventsFilter);
> if (catalogTimeline != null) {
> catalogTimeline.markEvent(FETCHED_HMS_EVENT_BATCH);
> }
> return events;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
