[ 
https://issues.apache.org/jira/browse/IMPALA-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824199#comment-17824199
 ] 

Michael Smith commented on IMPALA-12878:
----------------------------------------

I tried doing that in FinishUnregisterQuery. I think the challenge is that our 
clients don't have a good way to control closing a query twice. There seems to 
be some flow where Thrift's RPC will automatically close a connection, 
triggering session expiration and closing the query, then an explicit 
close_query can trigger this case.

> TestResultSpoolingCancellation.test_cancellation failed in UBSAN build
> ----------------------------------------------------------------------
>
>                 Key: IMPALA-12878
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12878
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 4.4.0
>            Reporter: Riza Suminto
>            Assignee: Michael Smith
>            Priority: Major
>              Labels: broken-build
>
> TestResultSpoolingCancellation.test_cancellation failed in UBSAN build. The 
> following are the error messages.
> {code:java}
> Error Message
> query_test/test_result_spooling.py:356: in test_cancellation     
> vector.get_value('cancel_delay')) util/cancel_util.py:99: in 
> cancel_query_and_validate_state     assert 'Invalid or unknown query handle' 
> in str(close_error) E   assert 'Invalid or unknown query handle' in 
> "ImpalaBeeswaxException:\n INNER EXCEPTION: <class 
> 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: Query not yet running\n" E    
> +  where "ImpalaBeeswaxException:\n INNER EXCEPTION: <class 
> 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: Query not yet running\n" = 
> str(ImpalaBeeswaxException())
> Stacktrace
> query_test/test_result_spooling.py:356: in test_cancellation
>     vector.get_value('cancel_delay'))
> util/cancel_util.py:99: in cancel_query_and_validate_state
>     assert 'Invalid or unknown query handle' in str(close_error)
> E   assert 'Invalid or unknown query handle' in "ImpalaBeeswaxException:\n 
> INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: Query 
> not yet running\n"
> E    +  where "ImpalaBeeswaxException:\n INNER EXCEPTION: <class 
> 'beeswaxd.ttypes.BeeswaxException'>\n MESSAGE: Query not yet running\n" = 
> str(ImpalaBeeswaxException())
> Standard Error
> SET 
> client_identifier=query_test/test_result_spooling.py::TestResultSpoolingCancellation::()::test_cancellation[query:selectl_returnflagfromtpch_parquet.lineitem|protocol:beeswax|exec_option:{'test_replan':1;'batch_size':0;'num_nodes':0;'disable_codegen_rows_threshold':0;'disa;
> -- executing against localhost:21000
> use tpch_parquet;
> -- 2024-03-05 23:36:03,429 INFO     MainThread: Started query 
> 8241403abf8b7dbb:4db1deee00000000
> SET 
> client_identifier=query_test/test_result_spooling.py::TestResultSpoolingCancellation::()::test_cancellation[query:selectl_returnflagfromtpch_parquet.lineitem|protocol:beeswax|exec_option:{'test_replan':1;'batch_size':0;'num_nodes':0;'disable_codegen_rows_threshold':0;'disa;
> SET spool_query_results=true;
> SET test_replan=1;
> SET batch_size=0;
> SET num_nodes=0;
> SET disable_codegen_rows_threshold=0;
> SET disable_codegen=False;
> SET abort_on_error=1;
> SET exec_single_node_rows_threshold=0;
> -- executing async: localhost:21000
> select l_returnflag from tpch_parquet.lineitem;
> -- 2024-03-05 23:36:03,437 INFO     MainThread: Started query 
> 4a44182cfdd8b9ff:657a80a800000000
> SET 
> client_identifier=query_test/test_result_spooling.py::TestResultSpoolingCancellation::()::test_cancellation[query:selectl_returnflagfromtpch_parquet.lineitem|protocol:beeswax|exec_option:{'test_replan':1;'batch_size':0;'num_nodes':0;'disable_codegen_rows_threshold':0;'disa;
> -- connecting to: localhost:21000
> -- 2024-03-05 23:36:03,437 INFO     Thread-24: Could not connect to ('::1', 
> 21000, 0, 0)
> Traceback (most recent call last):
>   File 
> "/data/jenkins/workspace/impala-cdw-master-staging-core-ubsan/repos/Impala/infra/python/env-gcc10.4.0/lib/python2.7/site-packages/thrift/transport/TSocket.py",
>  line 137, in open
>     handle.connect(sockaddr)
>   File 
> "/data/jenkins/workspace/impala-cdw-master-staging-core-ubsan/Impala-Toolchain/toolchain-packages-gcc10.4.0/python-2.7.16/lib/python2.7/socket.py",
>  line 228, in meth
>     return getattr(self._sock,name)(*args)
> error: [Errno 111] Connection refused
> -- fetching results from: <tests.common.impala_connection.OperationHandle 
> object at 0x7fd2b172a410>
> -- getting state for operation: 
> <tests.common.impala_connection.OperationHandle object at 0x7fd2b172a410>
> -- canceling operation: <tests.common.impala_connection.OperationHandle 
> object at 0x7fd2b172a410>
> -- closing query for operation handle: 
> <tests.common.impala_connection.OperationHandle object at 0x7fd2b172a410>
> -- getting runtime profile operation: 
> <tests.common.impala_connection.OperationHandle object at 0x7fd2b172a410>
> {code}
> Error message "Query not yet running" is recently introduced in IMPALA-12493.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to