[
https://issues.apache.org/jira/browse/IMPALA-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830073#comment-17830073
]
ASF subversion and git services commented on IMPALA-4545:
---------------------------------------------------------
Commit 266d7ec51c2de00e796d6c29ed0f5eb0972e74c1 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=266d7ec51 ]
IMPALA-4545: Simplify test dimension in test_decimal_casting.py
This patch splits precision and scale as independent dimensions and then
constrains them to yield a valid decimal type. With this split, core
exploration will have the same test dimension as pairwise exploration,
while exhaustive exploration still permutes all possible decimal types.
Also did minor refactoring to reduce test skipping and pass flake8.
After this patch, core exploration has 214 test items and exhaustive
exploration has 12312 test items. Before, they were 408 and 12464
respectively.
Testing:
- Pass test_decimal_casting.py in core and exhaustive exploration.
Change-Id: Ibe269e08a955097ad9e924d5d64b42438ad15be2
Reviewed-on: http://gerrit.cloudera.org:8080/21174
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> test_decimal_casting.py has invalid test vector under "pairwise" exploration
> strategy
> -------------------------------------------------------------------------------------
>
> Key: IMPALA-4545
> URL: https://issues.apache.org/jira/browse/IMPALA-4545
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 2.8.0
> Environment: ec2 c4.4xl, ubuntu 14.04
> Reporter: Jim Apple
> Assignee: Riza Suminto
> Priority: Major
>
> {noformat}
> ==================================== ERRORS
> ====================================
> _____________ ERROR collecting query_test/test_decimal_casting.py
> ______________
> conftest.py:157: in pytest_generate_tests
> metafunc.config.option.exploration_strategy)
> common/test_vector.py:116: in generate_test_vectors
> return self.__generate_pairwise_combinations()
> common/test_vector.py:133: in __generate_pairwise_combinations
> filter_func = self.is_valid)]
> ../infra/python/env/local/lib/python2.7/site-packages/metacomm/combinatorics/all_pairs2.py:36:
> in __init__
> raise Exception("option arrays must have at least one item")
> E Exception: option arrays must have at least one item
> generated xml file:
> /home/ubuntu/Impala/logs/ee_tests/results/TEST-impala-serial.xml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
