[
https://issues.apache.org/jira/browse/IMPALA-12978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835346#comment-17835346
]
ASF subversion and git services commented on IMPALA-12978:
----------------------------------------------------------
Commit 5c003cdcda604c43dd836571db02afcfbdc05dbc in impala's branch
refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5c003cdcd ]
IMPALA-12978: Fix impala-shell`s live progress with older Impalas
If the Impala server has an older version that does not contain
IMPALA-12048 then TExecProgress.total_fragment_instances will be
None, leading to error when checking total_fragment_instances > 0.
Note that this issue only comes with Python 3, in Python 2 None > 0
returns False.
Testing:
- Manually checked with a modified Impala that doesn't set
total_fragment_instances. Only the scanner progress bar is shown
in this case.
Change-Id: Ic6562ff6c908bfebd09b7612bc5bcbd92623a8e6
Reviewed-on: http://gerrit.cloudera.org:8080/21256
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Zihao Ye <[email protected]>
> IMPALA-12544 made impala-shell incompatible with old impala servers
> -------------------------------------------------------------------
>
> Key: IMPALA-12978
> URL: https://issues.apache.org/jira/browse/IMPALA-12978
> Project: IMPALA
> Issue Type: Bug
> Components: Clients
> Reporter: Csaba Ringhofer
> Assignee: Csaba Ringhofer
> Priority: Critical
>
> IMPALA-12544 uses "progress.total_fragment_instances > 0:", but
> total_fragment_instances is None if the server is older and does not know
> this Thrift member yet (added in IMPALA-12048).
> [https://github.com/apache/impala/blob/fb3c379f395635f9f6927b40694bc3dd95a2866f/shell/impala_shell.py#L1320]
>
> This leads to error messages in interactive shell sessions when progress
> reporting is enabled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
