[
https://issues.apache.org/jira/browse/IMPALA-13024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839468#comment-17839468
]
Riza Suminto commented on IMPALA-13024:
---------------------------------------
I'm testing this change on ASAN build. Will push this to gerrit if if pass core
tests.
{code:java}
diff --git a/be/src/scheduling/admission-controller.cc
b/be/src/scheduling/admission-controller.cc
index af14a70..1e30fac 100644
--- a/be/src/scheduling/admission-controller.cc
+++ b/be/src/scheduling/admission-controller.cc
@@ -1005,6 +1005,9 @@ bool AdmissionController::CanAdmitRequest(const
ScheduleState& state,
PoolStats* pool_stats = GetPoolStats(state);
bool default_group =
state.executor_group() == ImpalaServer::DEFAULT_EXECUTOR_GROUP_NAME;
+ bool default_coordinator_only =
+ state.executor_group() == ClusterMembershipMgr::EMPTY_GROUP_NAME
+ && state.request_pool() == RequestPoolService::DEFAULT_POOL_NAME;
if (!admit_from_queue && pool_stats->local_stats().num_queued > 0) {
*not_admitted_reason = Substitute(QUEUED_QUEUE_NOT_EMPTY,
pool_stats->local_stats().num_queued, GetStalenessDetailLocked(" "));
@@ -1017,7 +1020,7 @@ bool AdmissionController::CanAdmitRequest(const
ScheduleState& state,
max_requests, GetStalenessDetailLocked(" "));
return false;
}
- if (!default_group
+ if (!default_group && !default_coordinator_only
&& !HasAvailableSlots(
state, pool_cfg, not_admitted_reason, coordinator_resource_limited))
{
// All non-default executor groups are also limited by the number of
running queries {code}
> Several tests timeout waiting for admission
> -------------------------------------------
>
> Key: IMPALA-13024
> URL: https://issues.apache.org/jira/browse/IMPALA-13024
> Project: IMPALA
> Issue Type: Bug
> Reporter: Csaba Ringhofer
> Priority: Critical
>
> A bunch of seemingly unrelated tests failed with the following message:
> Example:
> query_test.test_spilling.TestSpillingDebugActionDimensions.test_spilling_aggs[protocol:
> beeswax | exec_option: {'mt_dop': 1, 'debug_action': None,
> 'default_spillable_buffer_size': '256k'} | table_format: parquet/none]
> {code}
> ImpalaBeeswaxException: E Query aborted:Admission for query exceeded
> timeout 60000ms in pool default-pool. Queued reason: Not enough admission
> control slots available on host ... . Needed 1 slots but 18/16 are already in
> use. Additional Details: Not Applicable
> {code}
> This happened in an ASAN build. Another test also failed which may be related
> to the cause:
> custom_cluster.test_admission_controller.TestAdmissionController.test_queue_reasons_slots
>
> {code}
> Timeout: query 'e1410add778cd7b0:c40812b900000000' did not reach one of the
> expected states [4], last known state 5
> {code}
> test_queue_reasons_slots seems to be know flaky test: IMPALA-10338
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
