[
https://issues.apache.org/jira/browse/IMPALA-13034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840598#comment-17840598
]
Quanlong Huang commented on IMPALA-13034:
-----------------------------------------
Yeah, IMPALA-9380 just helps the part of finalizing (unregistering) a query.
The HTTP requests come when the query is still running. We need a lock to
protect such read requests from concurrent modification on the profile.
Probably we can add a more fine-grained lock just for reading/writing the
profile and don't block client fetching query results.
> Add logs for slow HTTP requests dumping the profile
> ---------------------------------------------------
>
> Key: IMPALA-13034
> URL: https://issues.apache.org/jira/browse/IMPALA-13034
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Quanlong Huang
> Priority: Critical
>
> There are several endpoints in WebUI that can dump a query profile:
> /query_profile, /query_profile_encoded, /query_profile_plain_text,
> /query_profile_json
> The HTTP handler thread goes into ImpalaServer::GetRuntimeProfileOutput()
> which acquires lock of the ClientRequestState. This could blocks client
> requests in fetching query results. We should add warning logs when such HTTP
> requests run slow (e.g. when the profile is too large to download in a short
> time). IP address and other info of such requests should also be logged.
> Related codes:
> https://github.com/apache/impala/blob/f620e5d5c0bbdb0fd97bac31c7b7439cd13c6d08/be/src/service/impala-server.cc#L736
> https://github.com/apache/impala/blob/f620e5d5c0bbdb0fd97bac31c7b7439cd13c6d08/be/src/service/impala-beeswax-server.cc#L601
> https://github.com/apache/impala/blob/f620e5d5c0bbdb0fd97bac31c7b7439cd13c6d08/be/src/service/impala-hs2-server.cc#L207
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
