[ 
https://issues.apache.org/jira/browse/IMPALA-13058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844689#comment-17844689
 ] 

ASF subversion and git services commented on IMPALA-13058:
----------------------------------------------------------

Commit fdb87a755a2ac581b3144f1506b6e901ec8d2da2 in impala's branch 
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=fdb87a755 ]

IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1

Impala run over ARM machine shows 'arch_sys_counter' clock source being
used rather than more precise 'tsc'. This cause
MonotonicStopwatch::Now() to use 'CLOCK_MONOTONIC_COARSE' rather than
'CLOCK_MONOTONIC'. This is what printed near the beginning of impalad
log:

I0506 13:49:15.429359 355337 init.cc:600] OS distribution: Red Hat Enterprise 
Linux 8.8 (Ootpa)
OS version: Linux version 4.18.0-477.15.1.el8_8.aarch64 ...
Clock: clocksource: 'arch_sys_counter', clockid_t: CLOCK_MONOTONIC_COARSE

This difference in clock source causes test failure in
test_runtime_filters.py::TestRuntimeFilters::test_basic_filters. This
patch fixes the issue by initializing first_arrival_time_ and
completion_time_ fields of Coordinator::FilterState with -1 and accept 0
as valid value for those fields.

query_events_ initialization and start are also moved to the beginning
of ClientRequestState's contructor.

Testing:
- Tweak row_regex pattern in runtime_filters.test.
- Loop and pass test_runtime_filters.py in exhaustive mode 3 times
  in ARM machine.

Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58
Reviewed-on: http://gerrit.cloudera.org:8080/21405
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> TestRuntimeFilters.test_basic_filters failed on ARM builds
> ----------------------------------------------------------
>
>                 Key: IMPALA-13058
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13058
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>            Reporter: Wenzhe Zhou
>            Assignee: Riza Suminto
>            Priority: Major
>
> Stacktrace:
> query_test/test_runtime_filters.py:98: in test_basic_filters
>     self.run_test_case('QueryTest/runtime_filters', vector, 
> test_file_vars=vars)
> /data/jenkins/workspace/impala-cdw-master-exhaustive-release-arm/repos/Impala/tests/common/impala_test_suite.py:851:
>  in run_test_case
>     update_section=pytest.config.option.update_results)
> /data/jenkins/workspace/impala-cdw-master-exhaustive-release-arm/repos/Impala/tests/common/test_result_verifier.py:701:
>  in verify_runtime_profile
>     actual))
> E   AssertionError: Did not find matches for lines in runtime profile:
> E   EXPECTED LINES:
> E   row_regex: .*REMOTE.*ms.*ms.*true



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to