[
https://issues.apache.org/jira/browse/IMPALA-13067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847381#comment-17847381
]
ASF subversion and git services commented on IMPALA-13067:
----------------------------------------------------------
Commit 3a8eb999cbc746c055708425e071c30e3c00422e in impala's branch
refs/heads/master from Gabor Kaszab
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=3a8eb999c ]
IMPALA-13055: Some Iceberg metadata table tests don't assert
Some tests in the Iceberg metadata table suite use the following regex
to verify numbers in the output: [1-9]\d*|0
However, if this format is given, the test unconditionally passes.
This patch changes this format to \d+ and fixes the test results that
incorrectly passed before due to the test not asserting.
Opened IMPALA-13067 to investigate why the test framework works like
this for |0 in the regexes.
Change-Id: Ie47093f25a70253b3e6faca27d466d7cf6999fad
Reviewed-on: http://gerrit.cloudera.org:8080/21394
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Some regex make the tests unconditionally pass
> ----------------------------------------------
>
> Key: IMPALA-13067
> URL: https://issues.apache.org/jira/browse/IMPALA-13067
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Reporter: Gabor Kaszab
> Priority: Major
> Labels: test-framework
>
> This issue came out in the Iceberg metadata table tests where this regex was
> used:
> [1-9]\d*|0
>
> The "|0" part for some reason made the test framework confused and then
> regardless of what you provide as an expected result the tests passed. One
> workaround was to put the regex expression between parentheses. Or simply use
> "d+". https://issues.apache.org/jira/browse/IMPALA-13055 applied this second
> workaround on the tests.
> Some analysis would be great why this is the behavior of the test framework,
> and if it's indeed the issue of the framnework, we should fix it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
