[ 
https://issues.apache.org/jira/browse/IMPALA-13129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852181#comment-17852181
 ] 

ASF subversion and git services commented on IMPALA-13129:
----------------------------------------------------------

Commit e2e45401e2bead4090fd5c562709db521cbc6d38 in impala's branch 
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e2e45401e ]

IMPALA-13129: Move runtime filter skipping at registerRuntimeFilter

A DCHECK in hdfs-scanner.h was hit when skipping a MIN_MAX runtime
filter using RUNTIME_FILTER_IDS_TO_SKIP query option. This is because
HdfsScanNode.tryToComputeOverlapPredicate() is called and register a
TOverlapPredicateDesc during runtime filter generation, but the minmax
filter is then skipped later, causing backend to hit DCHECK.

This patch move the runtime filter skipping at registerRuntimeFilter()
so that HdfsScanNode.tryToComputeOverlapPredicate() will not be called
at all once a filter is skipped.

Testing:
- Add test in overlap_min_max_filters.test to explicitly skip a minmax
  runtime filter.
- Pass test_runtime_filters.py

Change-Id: I43c1c4abc88019aadaa85d2e3d0ecda417297bfc
Reviewed-on: http://gerrit.cloudera.org:8080/21477
Reviewed-by: Wenzhe Zhou <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Hit DCHECK when skipping MIN_MAX runtime filter
> -----------------------------------------------
>
>                 Key: IMPALA-13129
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13129
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Frontend
>    Affects Versions: Impala 4.4.0
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>
> A [DCHECK in 
> hdfs-scanner.h|https://github.com/apache/impala/blob/ce8078204e5995277f79e226e26fe8b9eaca408b/be/src/exec/hdfs-scanner.h#L199]
>  is hit when skipping a MIN_MAX runtime filter using 
> RUNTIME_FILTER_IDS_TO_SKIP query option. This is because during runtime 
> filter generation, HdfsScanNode.tryToComputeOverlapPredicate() is called and 
> register a 
> TOverlapPredicateDesc, but the minmax filter is then skipped later, causing 
> backend to hit DCHECK.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to