[
https://issues.apache.org/jira/browse/IMPALA-12093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17860659#comment-17860659
]
ASF subversion and git services commented on IMPALA-12093:
----------------------------------------------------------
Commit 100693d5adce3a5db38bb171cae4e9c0dec5e20e in impala's branch
refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=100693d5a ]
IMPALA-12093: impala-shell to preserve all cookies
Updates impala-shell to preserve all cookies by default, defined as
setting 'http_cookie_names=*'. Prior behavior of restricting cookies to
a user-specified list is preserved when 'http_cookie_names' is given any
value besides '*'. Setting 'http_cookie_names=' prevents any cookies
from being preserved.
Adds verbose output that prints all cookies that are preserved by the
HTTP client.
Existing cookie tests with LDAP still work. Adds a test where Impala
returns an extra cookie, and test verifies that verbose mode prints all
expected cookies.
Change-Id: Ic81f790288460b086ab218e6701e8115a996dfa7
Reviewed-on: http://gerrit.cloudera.org:8080/19827
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Michael Smith <[email protected]>
> impala-shell should preserve all cookies by default
> ---------------------------------------------------
>
> Key: IMPALA-12093
> URL: https://issues.apache.org/jira/browse/IMPALA-12093
> Project: IMPALA
> Issue Type: Improvement
> Components: Clients
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Assignee: Michael Smith
> Priority: Major
> Fix For: Impala 4.5.0
>
>
> Currently, impala-shell's http_cookie_names parameter specifies which cookies
> should be preserved and sent back with subsequent requests. This defaults to
> a couple well-known cookie names that Impala uses.
> In general, we don't know what proxies are between impala-shell and Impala,
> and we don't know what cookie name they rely on being preserved. As an
> example, Apache Knox can rely on a cookie it sets to route requests to the
> appropriate Impala coordinator. Limiting our cookie preservation to a small
> allow list makes this much more brittle and hard to use. Clients need to know
> the right list of cookies to put in http_cookie_names, and that is not
> obvious.
> It seems like the default behavior should be to preserve all cookies. We can
> keep a way to disallow or limit the cookies for unusual cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
