[
https://issues.apache.org/jira/browse/IMPALA-13214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867074#comment-17867074
]
Michael Smith commented on IMPALA-13214:
----------------------------------------
I think what happened here is that {{impala-shell -q 'set
disable_cached_reads=true'}} ran too quickly for the ImpalaShell utility.
Unrelated to any recent code changes.
This test uses {{run_impala_shell_cmd}} to test that a set command generates a
warning. It does that by
# Creating a ImpalaShell object:
https://github.com/apache/impala/blob/4.4.0/tests/shell/util.py#L154
# which starts the new process:
https://github.com/apache/impala/blob/4.4.0/tests/shell/util.py#L230
# then waits for the connected message:
https://github.com/apache/impala/blob/4.4.0/tests/shell/util.py#L266
However it expects the process to still be running when it waits, and tests for
that via {{self.shell_process.poll()}}. When that returns a process result,
init considers that an error and asserts False. So we see
{code}
AssertionError: Impala shell exited with return code 0
{code}
but the return code is 0, meaning the process ran successfully.
I have some ideas for fixing up cases like this.
> test_shell_commandline..test_removed_query_option failed with assertion
> failure
> -------------------------------------------------------------------------------
>
> Key: IMPALA-13214
> URL: https://issues.apache.org/jira/browse/IMPALA-13214
> Project: IMPALA
> Issue Type: Bug
> Components: Clients
> Affects Versions: Impala 4.5.0
> Reporter: Laszlo Gaal
> Assignee: Michael Smith
> Priority: Blocker
>
> Happened during a recent s3-arm-data-cache build.
> Python backtrace:
> {code}
> /data/jenkins/workspace/impala-asf-master-core-s3-arm-data-cache/repos/Impala/tests/shell/test_shell_commandline.py:305:
> in test_removed_query_option
> expect_success=True)
> shell/util.py:135: in run_impala_shell_cmd
> stderr_file=stderr_file)
> shell/util.py:155: in run_impala_shell_cmd_no_expect
> stdout_file=stdout_file, stderr_file=stderr_file)
> shell/util.py:271: in __init__
> "Impala shell exited with return code {0}".format(process_status)
> E AssertionError: Impala shell exited with return code 0
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
