[
https://issues.apache.org/jira/browse/IMPALA-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870601#comment-17870601
]
ASF subversion and git services commented on IMPALA-13264:
----------------------------------------------------------
Commit 1823604fed9044325b33bf7ce080103940e8f3eb in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1823604fe ]
IMPALA-13264: Use the toolchain's gcov for bin/coverage_helper.sh
Currently, bin/coverage_helper.sh will use the system gcov if
it is available and fall back to the toolchain version
otherwise. The toolchain's GCC always has gcov available and it
is useful to have the gcov version match our compiler version.
So, this switches bin/coverage_helper.sh to always use gcov from
the toolchain's GCC directory.
Testing:
- Generated a coverage report locally
Change-Id: Ia9abc42d6fbab510c36889a0038d14866c9cffa9
Reviewed-on: http://gerrit.cloudera.org:8080/21624
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> bin/coverage_helper.sh should always use gcov from the toolchain
> ----------------------------------------------------------------
>
> Key: IMPALA-13264
> URL: https://issues.apache.org/jira/browse/IMPALA-13264
> Project: IMPALA
> Issue Type: Task
> Components: Infrastructure
> Affects Versions: Impala 4.5.0
> Reporter: Joe McDonnell
> Priority: Major
>
> bin/coverage_helper.sh gets gcov from the toolchain if it is not installed on
> the system.
> {noformat}
> if ! which gcov > /dev/null; then
> export
> PATH="$PATH:$IMPALA_TOOLCHAIN_PACKAGES_HOME/gcc-$IMPALA_GCC_VERSION/bin"
> fi
> echo "Using gcov at `which gcov`"{noformat}
> Since the toolchain compiler can be different from the system compiler, I
> think it makes more sense to always use gcov from the toolchain's GCC. Then
> the gcov version will always match the GCC version.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
