[
https://issues.apache.org/jira/browse/IMPALA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873045#comment-17873045
]
ASF subversion and git services commented on IMPALA-13295:
----------------------------------------------------------
Commit bd1c548760900ceb0637fa98584a6cb88d365da6 in impala's branch
refs/heads/master from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=bd1c54876 ]
IMPALA-13295: Fix undefined name 'index' in tests/util/workload_management.py
This fixes the undefined name 'index' in
tests/util/workload_management.py detected by the new version of
bin/jenkins/critique-gerrit-review.py when comparing branch-4.4.0 and
HEAD.
Change-Id: I22afedffbb976c150a1705c880fe747ac2e22f29
Reviewed-on: http://gerrit.cloudera.org:8080/21659
Reviewed-by: Jason Fehr <[email protected]>
Reviewed-by: Riza Suminto <[email protected]>
Tested-by: Michael Smith <[email protected]>
> Undefined name 'index' in tests/util/workload_management.py
> -----------------------------------------------------------
>
> Key: IMPALA-13295
> URL: https://issues.apache.org/jira/browse/IMPALA-13295
> Project: IMPALA
> Issue Type: Bug
> Components: Test
> Reporter: Quanlong Huang
> Assignee: Quanlong Huang
> Priority: Major
> Fix For: Impala 4.5.0
>
>
> While testing the new version of script bin/jenkins/critique-gerrit-review.py
> to compare branch-4.4.0 and HEAD, it found an undefined name 'index' in
> tests/util/workload_management.py:
> {code:python}
> assert value == expected, ('per-host fragment instances incorrect.'
> ' expected="{0}" actual="{1}"').format(expected, data[index])
> {code}
> [https://github.com/apache/impala/blob/589dbd6f1a1247c365fa794e5b7ed992c2e1f2ab/tests/util/workload_management.py#L274-L275]
> This is due to this change only replace 'data[index]' with 'value' in the
> first line but forgot to do it in the second line:
> https://gerrit.cloudera.org/c/21358/11/tests/util/workload_management.py#274
> To avoid such issues in the future, we might need to improve flake8-diff to
> also look into several lines of codes around the changes.
> CC [~jasonmfehr], [~MikaelSmith], [~rizaon]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
