[ 
https://issues.apache.org/jira/browse/IMPALA-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873318#comment-17873318
 ] 

ASF subversion and git services commented on IMPALA-13252:
----------------------------------------------------------

Commit a24b98bd6dbe3e80f67ec9bfe1eeb193d759ac89 in impala's branch 
refs/heads/branch-4.4.1 from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a24b98bd6 ]

IMPALA-13252: Always use PrintId for TUniqueId

Thrift types provide their own overload of operator<<. In GCC, the
overload added in debug-util.h is preferred, but in Clang the first
overload (from Thrift generated code) is preferred. I don't see a good
way to augment the Thrift definition to use PrintId, so this patch
reverts the overload in debug-util.h and uses PrintId explicitly.

Change-Id: Ic536c12ed67d9d473c7ac7f1e05ebc537ff485d4
Reviewed-on: http://gerrit.cloudera.org:8080/21639
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Yida Wu <[email protected]>
Reviewed-by: Michael Smith <[email protected]>


> Filter update log message prints TUniqueId in non-standard format
> -----------------------------------------------------------------
>
>                 Key: IMPALA-13252
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13252
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 4.4.0
>            Reporter: Michael Smith
>            Assignee: Michael Smith
>            Priority: Major
>             Fix For: Impala 4.5.0
>
>
> Some error messages, such as
> {code}
> Filter update received for non-executing query with id: 
> TUniqueId(hi=-8482965541048796556, lo=3501357296473079808)
> {code}
> print query id as the raw Thrift type rather than our colon-delimited format, 
> e.g. "8a4673c8fbe83a74:309751e900000000". This makes it difficult to trace 
> queries through logs.
> Normalize on the colon-delimited format.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to