Riza Suminto created IMPALA-13319:
-------------------------------------
Summary: Avoid duplicate exec option declaration in py.test
Key: IMPALA-13319
URL: https://issues.apache.org/jira/browse/IMPALA-13319
Project: IMPALA
Issue Type: Improvement
Components: Test
Affects Versions: Impala 4.4.0
Reporter: Riza Suminto
Assignee: Riza Suminto
add_mandatory_exec_option() may replace existing option values in 'exec_option'
dimension, and may cause unintended test vector duplication. For example, the
following declaration will create two duplicate test vector, both with
"disable_codegen=False":
{code:java}
cls.ImpalaTestMatrix.add_dimension(create_exec_option_dimension(
disable_codegen_options=[False, True]))
add_mandatory_exec_option(cls, "disable_codegen", False){code}
add_exec_option_dimension() will create new test dimension for a 'key', but
does not insert it into 'exec_option' dimension until vector generation later.
It also does not validate if 'key' already exist in 'exec_option' dimension.
This can confuse test writer when they need to write constraint, because they
might look for the value at vector.get_value('exec_option')['key'] instead of
vector.get_value('key'), and vice versa.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
