[
https://issues.apache.org/jira/browse/IMPALA-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883127#comment-17883127
]
Joe McDonnell commented on IMPALA-13073:
----------------------------------------
This was fixed by this commit:
{noformat}
commit e06c7dcb9663a5df08a6bda025d82806762d019f
Author: Joe McDonnell <joemcdonn...@cloudera.com>
Date: Sun Apr 28 15:47:24 2024 -0700 IMPALA-13072: Increase verbosity to
print compilation commands
It is useful to be able to examine the compilation commands
to verify that custom flags are set (e.g. some components
use -fno-omit-frame-pointer, etc). Components that use
CMake often do not print the compilation command.
This modifies make invocations to pass in VERBOSE=1, which
prints the command being executed. This only passes in
VERBOSE=1 for make invocations that are doing compilation,
so it skips some locations that are only doing "make install"
after already compiling the project (or are header-only
projects).
Some projects don't respect VERBOSE=1. Boost has a special
-d+2 flag that turns on verbose output. Other projects like
CURL use configure's --disable-silent-rules flag to enable
verbose output.
The output is not too big and it gets redirected to a
file, so this does not make it configurable.
Testing:
- Ran a toolchain build and verified that the compilation
commands are in the output
Change-Id: I1a27bfe401c5def341b2e52f7d5e77d7f0e3a19e
Reviewed-on: http://gerrit.cloudera.org:8080/21470
Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com>
Tested-by: Joe McDonnell <joemcdonn...@cloudera.com>
{noformat}
> Toolchain builds should pass VERBOSE=1 into make
> ------------------------------------------------
>
> Key: IMPALA-13073
> URL: https://issues.apache.org/jira/browse/IMPALA-13073
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> It is useful to be able to examine the compilation flags for toolchain
> components. Sometimes we want to add --fno-omit-frame-pointers or add debug
> symbols with -g1 and verify that it actually gets set. For projects that use
> CMake, the output often does not print the compile command. CMake can produce
> a compilation database, but it is simpler to have make print the compilation
> command by adding VERBOSE=1. The output isn't that big and output gets
> redirected to a file, so it seems like we could leave it on by default.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
