[
https://issues.apache.org/jira/browse/IMPALA-13376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884385#comment-17884385
]
ASF subversion and git services commented on IMPALA-13376:
----------------------------------------------------------
Commit 93c64e7e9a771d72b860d1a6bdccc33d9f46f5ac in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=93c64e7e9 ]
IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
This patch adds documentation for AGG_MEM_CORRELATION_FACTOR and
LARGE_AGG_MEM_THRESHOLD option introduced in Apache Impala 4.4.0.
IMPALA-12548 fix behavior of AGG_MEM_CORRELATION_FACTOR. Higher value
will lower memory estimation, while lower value will result in higher
memory estimation. The documentation in ImpalaService.thrift, however,
says the opposite. This patch fix documentation in thrift file as well.
Testing:
- Run "make plain-html" in docs/ dir and confirm the output.
- Manually check with comments in
PlannerTest.testAggNodeMaxMemEstimate()
Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Reviewed-on: http://gerrit.cloudera.org:8080/21793
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
> Slight documentation mistake for AGG_MEM_CORRELATION_FACTOR
> -----------------------------------------------------------
>
> Key: IMPALA-13376
> URL: https://issues.apache.org/jira/browse/IMPALA-13376
> Project: IMPALA
> Issue Type: Documentation
> Components: Docs
> Affects Versions: Impala 4.4.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 4.5.0
>
>
> IMPALA-12548 fix behavior of AGG_MEM_CORRELATION_FACTOR. Higher value will
> lower memory estimation, while lower value will result in higher memory
> estimation. The documentation in
> [ImpalaService.thrift|https://github.com/apache/impala/blob/874e4fa117bdccfb8784c1987e5e3bf1ef4fbc1d/common/thrift/ImpalaService.thrift#L850-L851],
> however, says the opposite.
> {code:java}
> // Setting value 1.0 will result in an equal memory estimate as the default
> estimation
> // (no change). Defaults to 0.5. {code}
> AGG_MEM_CORRELATION_FACTOR was also never documented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
