[
https://issues.apache.org/jira/browse/IMPALA-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886516#comment-17886516
]
ASF subversion and git services commented on IMPALA-13396:
----------------------------------------------------------
Commit 9c87cf41bf326f6031605713c7eabf4c12255cf4 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=9c87cf41b ]
IMPALA-13396: Unify tmp dir management in CustomClusterTestSuite
There are many custom cluster tests that require creating temporary
directory. The temporary directory typically live within a scope of test
method and cleaned afterwards. However, some test do create temporary
directory directly and forgot to clean them afterwards, leaving junk
dirs under /tmp/ or $LOG_DIR.
This patch unify the temporary directory management inside
CustomClusterTestSuite. It introduce new 'tmp_dir_placeholders' arg in
CustomClusterTestSuite.with_args() that list tmp dirs to create.
'impalad_args', 'catalogd_args', and 'impala_log_dir' now accept
formatting pattern that is replaceable by a temporary dir path, defined
through 'tmp_dir_placeholders'.
There are few occurrences where mkdtemp is called and not replaceable by
this work, such as tests/comparison/cluster.py. In that case, this patch
change them to supply prefix arg so that developer knows that it comes
from Impala test script.
This patch also addressed several flake8 errors in modified files.
Testing:
- Pass custom cluster tests in exhaustive mode.
- Manually run few modified tests and observe that the temporary dirs
are created and removed under logs/custom_cluster_tests/ as the tests
go.
Change-Id: I8dd665e8028b3f03e5e33d572c5e188f85c3bdf5
Reviewed-on: http://gerrit.cloudera.org:8080/21836
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Unify temporary dir management in CustomClusterTestSuite
> --------------------------------------------------------
>
> Key: IMPALA-13396
> URL: https://issues.apache.org/jira/browse/IMPALA-13396
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> There are many custom cluster test that require creating temporary director.
> The temporary directory typically live within a scope of test method and
> cleaned afterwards. However, some test do create temporary directly and
> forgot to clean them afterwards, leaving junk dirs under /tmp/ or $LOG_DIR.
> We can unify the temporary directory management inside
> CustomClusterTestSuite. Some argument of CustomClusterTestSuite.with_args(),
> such as 'impalad_args', 'catalogd_args', and 'impala_log_dir', should accept
> formatting pattern that is replaceable by a temporary dir path.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
