[
https://issues.apache.org/jira/browse/IMPALA-12908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889870#comment-17889870
]
ASF subversion and git services commented on IMPALA-12908:
----------------------------------------------------------
Commit 0767ae065a9bf3023ad0be3d98ebad0e4d0c32fa in impala's branch
refs/heads/master from Yida Wu
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=0767ae065 ]
IMPALA-12908: (Addendum) use RUNTIME_FILTER_WAIT_TIME_MS for tuple cache TPC
testing
When runtime filters arrive after tuple caching has occurred, they
can't filter the cached results. This can lead to larger tuple caching
result sets than expected, causing correctness check failures in TPC
tests.
While other solutions may exist, extending RUNTIME_FILTER_WAIT_TIME_MS
is a simple fix by ensuring runtime filters are applied before tuple
caching.
Also set the query option enable_tuple_cache_verification to false
by default, as the filter arrival time may affect the correctness
check. To avoid flaky tests, change to use a more conservative
approach and only enable the correctness check when explicitly
specified by the testcase.
Tests:
Verified TPC tests pass correctness checks with increased runtime
filter wait time.
Change-Id: Ie70a87344c436ce8e2073575df5c5bf762ef562d
Reviewed-on: http://gerrit.cloudera.org:8080/21898
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Add a correctness verification mode for tuple caching
> -----------------------------------------------------
>
> Key: IMPALA-12908
> URL: https://issues.apache.org/jira/browse/IMPALA-12908
> Project: IMPALA
> Issue Type: Task
> Components: Backend
> Affects Versions: Impala 4.4.0
> Reporter: Joe McDonnell
> Assignee: Yida Wu
> Priority: Major
> Fix For: Impala 4.5.0
>
>
> To get more coverage of tuple caching correctness, it would be useful to have
> automated correctness checking for tuple caching. In this mode, the tuple
> cache node would fetch results from its child, persist the new results to
> disk, then compare the new results to the cache contents at the end. The goal
> is to be able to run a variety of queries, including various end-to-end tests
> and verify that there is no variability in the results stored to the cache.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
