[
https://issues.apache.org/jira/browse/IMPALA-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889869#comment-17889869
]
ASF subversion and git services commented on IMPALA-13431:
----------------------------------------------------------
Commit 19678ae65c96b09999cbe728cb0e7e1ae2301fd2 in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=19678ae65 ]
IMPALA-13431: Deflake TestLogging.test_excessive_cerr_ignore_pid
On a couple UBSAN runs, test_excessive_cerr_ignore_pid sometimes
fails find the message providing the next path in the last line
of the ERROR log file. The logs aren't preserved, so we don't know
the exact contents of the log file.
This does two things:
1. It changes the test to preserve the log file on failure by
copying from the temporary directory to a directory that
will last past the end of the test. This gives us data to
work with if we see this again.
2. A theory is that an extra line or two of logging could go to
the file after it writes the message with the next path.
This changes the test to check the last 3 lines of the log
file for the message providing the next path.
Testing:
- Ran test with UBSAN
Change-Id: I4745184e983ee5669822059289aab18caf0b72a9
Reviewed-on: http://gerrit.cloudera.org:8080/21926
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> custom_cluster.test_breakpad.TestLogging.test_excessive_cerr_ignore_pid fails
> on UBSAN
> --------------------------------------------------------------------------------------
>
> Key: IMPALA-13431
> URL: https://issues.apache.org/jira/browse/IMPALA-13431
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 4.5.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Critical
> Labels: broken-build, flaky
>
> custom_cluster.test_breakpad.TestLogging.test_excessive_cerr_ignore_pid hits
> this failure:
> {noformat}
> custom_cluster/test_breakpad.py:509: in test_excessive_cerr_ignore_pid
> match_pid=False)
> custom_cluster/test_breakpad.py:487: in start_excessive_cerr_cluster
> self.assert_logs(daemon, max_log_count_end, expected_log_max_bytes)
> custom_cluster/test_breakpad.py:443: in assert_logs
> assert next_path in last_line
> E assert
> '/tmp/tmpMjrfcX/impalad.impala-ec2-centos79-m6i-4xlarge-xldisk-0032.hostname.jenkins.log.ERROR.20240819-051032.14446'
> in '22573865'{noformat}
> I saw this on a UBSAN test run, but it is intermittent and low frequency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
