[
https://issues.apache.org/jira/browse/IMPALA-13349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895708#comment-17895708
]
ASF subversion and git services commented on IMPALA-13349:
----------------------------------------------------------
Commit 88e0e4e8baa97f7fded12230b14232dc85cf6d79 in impala's branch
refs/heads/master from Noemi Pap-Takacs
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=88e0e4e8b ]
IMPALA-13334: Fix test_sort.py DCHECK hit when max_sort_run_size>0
test_sort.py declared 'max_sort_run_size' query option, but it
silently did not exercise it. Fixing the query option declaration
in IMPALA-13349 using helper function add_exec_option_dimension()
revealed a DCHECK failure in sorter.cc. In some cases the length
of an in-memory run could exceed 'max_sort_run_size' by 1 page.
This patch fixed the DCHECK failure by strictly enforcing the
'max_sort_run_size' limit.
Memory limits were also adjusted in test_sort.py according to
the memory usage of the different sort run sizes.
Additionally, the 'MAX_SORT_RUN_SIZE' query option's valid range was
relaxed. Instead of throwing an error, negative values also disable
the run size limitation, just as the default: '0'.
Testing:
- E2E tests in sort.py
- set test
Change-Id: I943d8edcc87df168448a174d6c9c6b46fe960eae
Reviewed-on: http://gerrit.cloudera.org:8080/21777
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Fix remaining tests that have unexercised exec option dimensions
> ----------------------------------------------------------------
>
> Key: IMPALA-13349
> URL: https://issues.apache.org/jira/browse/IMPALA-13349
> Project: IMPALA
> Issue Type: Bug
> Components: Test
> Affects Versions: Impala 4.5.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 4.5.0
>
>
> These are remaining tests that caught with WARNING log about declaring exec
> option dimension but not exercising them (added by IMPALA-13323).
> {code:java}
> tests/query_test/test_compressed_formats.py
> tests/query_test/test_insert.py
> tests/query_test/test_insert_parquet.py
> tests/query_test/test_mt_dop.py
> tests/query_test/test_parquet_stats.py
> tests/query_test/test_sort.py {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
