[
https://issues.apache.org/jira/browse/IMPALA-13334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895707#comment-17895707
]
ASF subversion and git services commented on IMPALA-13334:
----------------------------------------------------------
Commit 88e0e4e8baa97f7fded12230b14232dc85cf6d79 in impala's branch
refs/heads/master from Noemi Pap-Takacs
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=88e0e4e8b ]
IMPALA-13334: Fix test_sort.py DCHECK hit when max_sort_run_size>0
test_sort.py declared 'max_sort_run_size' query option, but it
silently did not exercise it. Fixing the query option declaration
in IMPALA-13349 using helper function add_exec_option_dimension()
revealed a DCHECK failure in sorter.cc. In some cases the length
of an in-memory run could exceed 'max_sort_run_size' by 1 page.
This patch fixed the DCHECK failure by strictly enforcing the
'max_sort_run_size' limit.
Memory limits were also adjusted in test_sort.py according to
the memory usage of the different sort run sizes.
Additionally, the 'MAX_SORT_RUN_SIZE' query option's valid range was
relaxed. Instead of throwing an error, negative values also disable
the run size limitation, just as the default: '0'.
Testing:
- E2E tests in sort.py
- set test
Change-Id: I943d8edcc87df168448a174d6c9c6b46fe960eae
Reviewed-on: http://gerrit.cloudera.org:8080/21777
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> test_sort.py hit DCHECK when max_sort_run_size>0
> ------------------------------------------------
>
> Key: IMPALA-13334
> URL: https://issues.apache.org/jira/browse/IMPALA-13334
> Project: IMPALA
> Issue Type: Bug
> Components: Backend, Test
> Reporter: Riza Suminto
> Assignee: Noemi Pap-Takacs
> Priority: Major
>
> test_sort.py declare 'max_sort_run_size' query option, but has silently not
> exercising it. Fixing the query option declaration using helper function
> add_exec_option_dimension() reveals a DCHECK failure in sorter.cc
> {code:java}
> F0827 16:45:38.425906 2405388 sorter.cc:1183]
> 054e9b0e1fecdaaf:298af36900000000] Check failed: !*allocation_failed &&
> unsorted_run_->run_size() == inmem_run_max_pages_{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
