[ 
https://issues.apache.org/jira/browse/IMPALA-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896825#comment-17896825
 ] 

ASF subversion and git services commented on IMPALA-13539:
----------------------------------------------------------

Commit fe3f82179fa0726af0645d01f90a2bf966175b75 in impala's branch 
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=fe3f82179 ]

IMPALA-13539: Fix TestCalcitePlanner.test_calcite_frontend for non-HDFS

TestCalcitePlanner.test_calcite_frontend runs an explain plan
and matches the expected output. On HDFS that includes "SCAN HDFS",
but on S3 and other non-HDFS filesystems, that can be "SCAN S3".
Similarly, "HDFS partitions" can be "S3 partitions". This changes
the expected output to make it insensitive to these differences.

Testing:
 - Ran test case locally and on S3

Change-Id: I7ddf919558a7ad622d7571283ad8a2e069c69f14
Reviewed-on: http://gerrit.cloudera.org:8080/22044
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> TestCalcitePlanner.test_calcite_frontend fails on non-HDFS test jobs
> --------------------------------------------------------------------
>
>                 Key: IMPALA-13539
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13539
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Frontend
>    Affects Versions: Impala 4.5.0
>            Reporter: Joe McDonnell
>            Assignee: Joe McDonnell
>            Priority: Critical
>              Labels: broken-build
>
> On S3 and other non-HDFS jobs, TestCalcitePlanner.test_calcite_frontend fails 
> with this:
> {noformat}
> custom_cluster/test_calcite_planner.py:40: in test_calcite_frontend
>     self.run_test_case('QueryTest/calcite', vector, use_db=unique_database)
> common/impala_test_suite.py:849: in run_test_case
>     self.__verify_results_and_errors(vector, test_section, result, use_db)
> common/impala_test_suite.py:656: in __verify_results_and_errors
>     replace_filenames_with_placeholder)
> common/test_result_verifier.py:520: in verify_raw_results
>     VERIFIER_MAP[verifier](expected, actual)
> common/test_result_verifier.py:290: in verify_query_result_is_subset
>     unicode(expected_row), unicode(actual_results))
> E   AssertionError: Could not find expected row row_regex:.*00:SCAN HDFS.* in 
> actual rows:
> E   '   S3 partitions=4/4 files=4 size=460B'
> E   '   row-size=89B cardinality=8'
> E   '00:SCAN S3 [functional.alltypestiny]'
> E   '01:EXCHANGE [UNPARTITIONED]'
> E   'PLAN-ROOT SINK'
> E   '|'
> E   '|'{noformat}
> It is looking for SCAN HDFS, but non-HDFS filesystems will have a different 
> message. We should change what it expects.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to