Joe McDonnell created IMPALA-13604:
--------------------------------------

             Summary: Thrift generated Python/Java code doesn't get regenerated 
when deleted
                 Key: IMPALA-13604
                 URL: https://issues.apache.org/jira/browse/IMPALA-13604
             Project: IMPALA
          Issue Type: Bug
          Components: Infrastructure
    Affects Versions: Impala 4.5.0
            Reporter: Joe McDonnell


Thrift generated Python code lives in shell/gen-py. If someone deletes 
shell/gen-py and then runs "make shell_tarball", it will fail because the 
directory and Thrift-generated code doesn't get regenerated. This is also true 
for Thrift-generated Java code. shell_tarball does depend on gen-deps, which 
would be able to generate those files, but gen-deps doesn't actually know which 
files are associated with Python or Java.

The CMake code that generates Thrift knows a little bit about which files are 
generated for C++, but it does not have similar logic for Java or Python. If we 
could provide the expected file names in common/thrift/CMakeLists.txt, then it 
should be able to regenerate those files if they are deleted.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to