[
https://issues.apache.org/jira/browse/IMPALA-13596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909104#comment-17909104
]
ASF subversion and git services commented on IMPALA-13596:
----------------------------------------------------------
Commit 6d715fe7dc2ff2fa549952d5eac384a77bc0357b in impala's branch
refs/heads/master from Andrew Sherman
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6d715fe7d ]
IMPALA-13596: Add warnings and exceptions to reading of fair-scheduler file.
The fair-scheduler file contains part of the configuration for Admission
Control. This change adds some better error handling to the parsing of
this file. Where it is safe to do so, new exceptions are thrown; this
will cause Impala to refuse to start. This is consistent with other
serious configuration errors. Where new exceptions might cause problems
with existing configurations, or for less dangerous faults, new warnings
are written to the server log.
For the recently added User Quota configuration (IMPALA-12345) throw an
exception when a duplicate snippet of configuration is found.
New warning log messages are added for these cases:
- when a user quota at the leaf level is completely ignored because of
a user quota at the root level
- when there is no user ACL on a leaf level queue. This prevents any
queries from being submitted to the queue.
Change-Id: Idcd50442ce16e7c4346c6da1624216d694f6f44d
Reviewed-on: http://gerrit.cloudera.org:8080/22209
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Verify Admission Control configuration at startup
> -------------------------------------------------
>
> Key: IMPALA-13596
> URL: https://issues.apache.org/jira/browse/IMPALA-13596
> Project: IMPALA
> Issue Type: Bug
> Affects Versions: Impala 4.4.0
> Reporter: Andrew Sherman
> Assignee: Andrew Sherman
> Priority: Major
>
> The Admission Control configuration is split across the two files
> -fair_scheduler_allocation_path=fair-scheduler.xml
> -llama_site_path=llama-site.xml
> We lazily load the configuration for a pool when a query is submitted to that
> pool. This is probably not a good time to fail the server.
> In addition a possibly dangerous configuration for a pool in the XML files
> might never actually be used.
> Add a configuration verification step at server startup. This will log
> warning messages if there is an inconsistency in the configuration.
> There could be multiple checks, for example we could flag if a Root level
> User Quota value is less than a pool level User Quota.
> We could also detect duplicate entries in the configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
