[
https://issues.apache.org/jira/browse/IMPALA-12832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910423#comment-17910423
]
ASF subversion and git services commented on IMPALA-12832:
----------------------------------------------------------
Commit e7c97439d12644af2a59bcd893aa7b8bdcb83b36 in impala's branch
refs/heads/master from Sai Hemanth Gantasala
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e7c97439d ]
IMPALA-12141: EP shouldn't fail while releasing write lock if the lock
is not held previously
Without IMPALA-12832, Event Processor (EP) is going into error state
when there is an issue while obtaining a table write lock because the
finally-clause of releaseWriteLock() is always invoked even if the lock
is not held by current thread. This patch addresses the problem by
checking if the table holds write lock before releasing it.
Note: With IMPALA-12832, the EP invalidates the table when an error is
encountered which is still an overhead. With this patch EP will neither
goes into error state nor invalidates when this issue is encountered.
Testing:
- Added an end-to-end to verify the same.
Change-Id: Ib2e4c965796dd515ab8549efa616f72510ca447f
Reviewed-on: http://gerrit.cloudera.org:8080/22080
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> EventProcessor shouldn't stop for failures in single-table event
> ----------------------------------------------------------------
>
> Key: IMPALA-12832
> URL: https://issues.apache.org/jira/browse/IMPALA-12832
> Project: IMPALA
> Issue Type: Bug
> Components: Catalog
> Reporter: Quanlong Huang
> Assignee: Venugopal Reddy K
> Priority: Critical
> Fix For: Impala 4.4.0
>
>
> EventProcessor goes into the ERROR/NEEDS_INVALIDATE state when it hits
> unexpected failures in processing an event. The cause are usually bugs. When
> it stops, all tables that need sync will be impacted. However, the event
> might just a single-table event (in contrast to multi-table events like
> RenameTable, DropDatabaseCascade, CommitTxn, AbortTxn). We can consider
> skipping the event and just invalidating the table.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
