[
https://issues.apache.org/jira/browse/IMPALA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910443#comment-17910443
]
ASF subversion and git services commented on IMPALA-13638:
----------------------------------------------------------
Commit 21ef3e6ffe997c3dbb71e1d7a92844fb31387a92 in impala's branch
refs/heads/master from Andrew Sherman
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=21ef3e6ff ]
IMPALA-13638: Translate apostrophe to underscore in Prometheus metric names.
Impala has some metrics that reflect the state of the JVM. Some of these
metrics have names that are partly composed of the names of the
MemoryPoolMXBean objects in the Java virtual machine. In Jdk 8 these
are names like "Code Cache" and "PS Eden Space". In Jdk 11 these names
include apostrophe characters, for example "CodeHeap 'profiled
nmethods'". The derived metric names work OK for Impala in both the
webui and in json output. However the apostrophe character is illegal
in Prometheus metric names per
https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels
and these metrics cannot be consumed by Prometheus. Fix this by adding
the apostrophe to the list of characters that are mapped to underscores
when we translate the metric names for Prometheus metrics.
TESTING:
Extended the test_prometheus_metrics test to parse all generated
Prometheus metrics. Ran the test with Jdk 11 where it failed without
the server fix
Change-Id: I557b123c075dff0b14ac527de08bc6177bd2a3f6
IMPALA-13596: first cut at tidied code
Reviewed-on: http://gerrit.cloudera.org:8080/22295
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Translate apostrophe to underscore in Prometheus metric names.
> --------------------------------------------------------------
>
> Key: IMPALA-13638
> URL: https://issues.apache.org/jira/browse/IMPALA-13638
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 4.4.0
> Reporter: Andrew Sherman
> Assignee: Andrew Sherman
> Priority: Critical
>
> Impala has some metrics that reflect the state of the JVM. Some of these
> metrics have names that are partly composed of the names of the
> MemoryPoolMXBean objects in the Java virtual machine. In Jdk8 these are names
> like "Code Cache" and "PS Eden Space". In Jdk11 these names include
> apostrophe characters, for example "CodeHeap 'profiled nmethods'". The
> derived metric names work OK for Impala in both the webui and in json output.
> However the apostrophe character is illegal in Prometheus metric names per
> https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels and
> these metrics cannot be consumed by Prometheus. Fix this by adding the
> apostrophe to the list of characters that are mapped to underscores when we
> translate the metric names for Prometheus metrics.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
