[
https://issues.apache.org/jira/browse/IMPALA-13642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911357#comment-17911357
]
ASF subversion and git services commented on IMPALA-13642:
----------------------------------------------------------
Commit 134de01a59580854d5050186db9b35a0a54cd8c6 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=134de01a5 ]
IMPALA-13642: Fix unused test vector in test_scanners.py
Several test vectors were ignored in test_scanners.py. This cause
repetition of the same test without actually varying the test
exec_option nor debug_action.
This patch fix it by:
- Use execute_query() instead of client.execute()
- Passing vector.get_value('exec_option') when executing test query.
Repurpose ImpalaTestMatrix.embed_independent_exec_options to deepcopy
'exec_option' dimension during vector generation. Therefore, each test
execution will have unique copy of 'exec_option' for them self.
This patch also adds flake8-unused-arguments plugin into
critique-gerrit-review.py and py3-requirements.txt so we can catch this
issue during code review. impala-flake8 is also updated to use
impala-python3-common.sh. Adds flake8==3.9.2 in py3-requirements.txt,
which is the highest version that has compatible dependencies with
pylint==2.10.2.
Drop unused 'dryrun' parameter in get_catalog_compatibility_comments
method of critique-gerrit-review.py.
Testing:
- Run impala-flake8 against test_scanners.py and confirm there is no
more unused variable.
- Run and pass test_scanners.py in core exploration.
Change-Id: I3b78736327c71323d10bcd432e162400b7ed1d9d
Reviewed-on: http://gerrit.cloudera.org:8080/22301
Reviewed-by: Michael Smith <[email protected]>
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Several test vector is being ignored in test_scanners.py
> --------------------------------------------------------
>
> Key: IMPALA-13642
> URL: https://issues.apache.org/jira/browse/IMPALA-13642
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> Several test vector is being unused in test_scanners.py. This cause
> repetition of the same test without actually varying the test exec_option nor
> debug_action. These are some that caught by flake8-unused-arguments in
> current
> [HEAD|https://github.com/apache/impala/blob/99529db6ad62ddc34cbfd924d7e41b1fce5b60a2/tests/query_test/test_scanners.py].
> {noformat}
> tests/query_test/test_scanners.py:385:50: U100 Unused argument 'v'
> tests/query_test/test_scanners.py:425:61: W504 line break after binary
> operator
> tests/query_test/test_scanners.py:432:34: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:643:39: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:652:32: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:790:48: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:843:41: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:888:34: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:900:48: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:967:39: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:1051:53: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:1151:37: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:1194:40: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:1410:34: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:1523:57: W504 line break after binary
> operator
> tests/query_test/test_scanners.py:1524:57: W504 line break after binary
> operator
> tests/query_test/test_scanners.py:1525:57: W504 line break after binary
> operator
> tests/query_test/test_scanners.py:1571:59: W504 line break after binary
> operator
> tests/query_test/test_scanners.py:1614:50: U100 Unused argument 'v'
> tests/query_test/test_scanners.py:1616:44: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:1619:38: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:1677:41: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:1886:33: U100 Unused argument 'vector'
> tests/query_test/test_scanners.py:2061:36: U100 Unused argument 'vector'
> {noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
