[ 
https://issues.apache.org/jira/browse/IMPALA-13743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925278#comment-17925278
 ] 

ASF subversion and git services commented on IMPALA-13743:
----------------------------------------------------------

Commit 4aea5d6923bb5aac8423295b918c59bac9fcaf9c in impala's branch 
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=4aea5d692 ]

IMPALA-13743: Fix setup_method calls at test_admission_controller.py

IMPALA-13694 reveals an issue in setup_method calls of
TestAdmissionControllerWithACService and
TestAdmissionControllerStressWithACService. They should be called with
their own class name instead of the superclass name.

Testing:
- Pass TestAdmissionControllerWithACService and
  TestAdmissionControllerStressWithACService in exhaustive exploration.

Change-Id: I092c4f397cba1908245ccb30111176190b2182ff
Reviewed-on: http://gerrit.cloudera.org:8080/22465
Reviewed-by: Jason Fehr <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> setup_method invocation is wrong at test_admission_controller.py
> ----------------------------------------------------------------
>
>                 Key: IMPALA-13743
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13743
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Test
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>              Labels: broken-build
>
> IMPALA-13694 reveals an issue in setup_method calls of 
> TestAdmissionControllerWithACService and 
> TestAdmissionControllerStressWithACService. They should be called with its 
> own class name instead of the superclass name.
> [https://github.com/apache/impala/blob/d3b6cbcc20a4ff175e9b36f476fc44f329793e1e/tests/custom_cluster/test_admission_controller.py#L1798]
> [https://github.com/apache/impala/blob/d3b6cbcc20a4ff175e9b36f476fc44f329793e1e/tests/custom_cluster/test_admission_controller.py#L2620]
> They are run in exhaustive exploration, therefore IMPALA-13694 able to pass 
> precommit tests.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to